Skip to content

Remove unused helper mixins #1084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dreikanter merged 4 commits into from
Jul 18, 2026
Merged

Remove unused helper mixins #1084

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bf6bd05
Remove ApplicationHelper include
dreikanter Jul 18, 2026
ea62b65
Remove ApplicationHelper include
dreikanter Jul 18, 2026
b1fed7f
Use helper proxy in feed filter dropdown
dreikanter Jul 18, 2026
97f3f03
Use helper proxy in sort dropdown
dreikanter Jul 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/components/feed_filter_dropdown_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
aria-haspopup="true"
aria-expanded="false">
<span><%= button_label %></span>
<%= icon("chevron-down", css_class: "size-4 text-muted") %>
<%= helpers.icon("chevron-down", css_class: "size-4 text-muted") %>
</button>
<div
id="<%= menu_id %>"
Expand All @@ -22,7 +22,7 @@
<label for="<%= menu_id %>-search" class="sr-only">Search feeds</label>
<div class="relative">
<div class="pointer-events-none absolute inset-y-0 start-0 flex items-center ps-3">
<%= icon("search", css_class: "size-4 text-muted") %>
<%= helpers.icon("search", css_class: "size-4 text-muted") %>
</div>
<input
type="text"
Expand Down
2 changes: 0 additions & 2 deletions app/components/feed_filter_dropdown_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
class FeedFilterDropdownComponent < ViewComponent::Base
include ApplicationHelper

def initialize(feeds:, selected_feed:, sort_params:, menu_id:)
@feeds = feeds
@selected_feed = selected_feed
Expand Down
6 changes: 3 additions & 3 deletions app/components/sort_dropdown_component.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
class="inline-flex items-center justify-center whitespace-nowrap rounded-md border border-border bg-surface px-4 py-2 text-base font-semibold text-body shadow-sm transition hover:bg-surface-muted focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-1 gap-2"
aria-haspopup="true"
aria-expanded="false">
<%= icon(direction_icon, css_class: "size-4 text-muted") %>
<%= helpers.icon(direction_icon, css_class: "size-4 text-muted") %>
<span class="flex items-center gap-2">
<span><%= presenter.current_title %></span>
<span class="sr-only"><%= direction_label %></span>
</span>
<%= icon("chevron-down", css_class: "size-4 text-muted") %>
<%= helpers.icon("chevron-down", css_class: "size-4 text-muted") %>
</button>
<div
id="<%= menu_id %>"
Expand All @@ -26,7 +26,7 @@
<span><%= option.title %></span>
<% if option.icon_name.present? %>
<span class="flex items-center text-muted">
<%= icon(option.icon_name, css_class: "size-4 text-muted") %>
<%= helpers.icon(option.icon_name, css_class: "size-4 text-muted") %>
<span class="sr-only"><%= option.active_direction == "asc" ? "Ascending" : "Descending" %></span>
</span>
<% end %>
Expand Down
2 changes: 0 additions & 2 deletions app/components/sort_dropdown_component.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
class SortDropdownComponent < ViewComponent::Base
include ApplicationHelper

def initialize(presenter:, menu_id:)
@presenter = presenter
@menu_id = menu_id
Expand Down