feat: ✨ add minimal conversion log with chunk information#290
Open
signekb wants to merge 21 commits into
Open
Conversation
So it's easy to filter on register name in the conversion log.
Including adding `knitr` to "Suggests"
With this, add `tarchetypes` to "Suggests".
signekb
changed the title
This reverts commit 7ed11aa.
…ps://github.com/dp-next/fastreg into feat/add-minimal-conversion-log-with-chunk-info
signekb
commented
May 3, 2026
Comment on lines
40
to
42
| skip_if( | ||
| Sys.info()[["sysname"]] == "Windows" && | ||
| # Copied directly from `testthat:::on_ci()`. |
Contributor
Author
There was a problem hiding this comment.
Maybe this part can be removed now?
lwjohnst86
requested changes
May 18, 2026
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Nice! Minor changes, mostly around naming
github-project-automation
Bot
moved this from In review
to In progress
in Platform development
Co-authored-by: Luke W. Johnston <lwjohnst86@users.noreply.github.com>
It's just more explicit.
So that we can call `conversion_log` from `tar_read`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #287 (implements first section, no schema and schema diff yet).
Needs a thorough review.
Checklist
just run-all