Skip to content

feat(json): generate syntax_kind.mbt via loomgen --seed (#571)#696

Merged
dowdiness merged 1 commit into
mainfrom
feat/571-json-syntax-kind-seed
Jul 11, 2026
Merged

feat(json): generate syntax_kind.mbt via loomgen --seed (#571)#696
dowdiness merged 1 commit into
mainfrom
feat/571-json-syntax-kind-seed

Conversation

@dowdiness

Copy link
Copy Markdown
Owner

Closes #571

Replace hand-written examples/json/syntax_kind.mbt with generated output from loomgen's --seed path, matching the lambda workflow.

Key differences from hand-written version:

  • from_raw uses pub impl @seam.FromRawKind (trait impl, matching lambda)
  • from_raw fallback is ErrorNode instead of ErrorToken (matches term kind annotation)
  • Adds IsTrivia and IsError trait impls (were missing in hand-written)

Regenerated examples/json/pkg.generated.mbti for new trait impl signatures.
Added CI step to verify json syntax_kind.mbt regeneration stays in sync.

moon test --target native: 3309/3309 pass

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dowdiness, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 16 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a94e3af1-90d7-4e4b-b58a-63bd9b5276a6

📥 Commits

Reviewing files that changed from the base of the PR and between 1af41fb and a2c04b4.

📒 Files selected for processing (3)
  • .github/workflows/ci.yml
  • examples/json/pkg.generated.mbti
  • examples/json/syntax_kind.mbt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/571-json-syntax-kind-seed

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dowdiness dowdiness merged commit 6a6ad61 into main Jul 11, 2026
38 checks passed
@dowdiness dowdiness deleted the feat/571-json-syntax-kind-seed branch July 11, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

examples/json: generate syntax_kind.mbt via loomgen --seed (issue #565 step 3)

1 participant