Skip to content

fix(grammar): suppress shrink warnings for consumers#685

Merged
dowdiness merged 3 commits into
mainfrom
fix/suppress-grammar-shrink-warnings
Jul 11, 2026
Merged

fix(grammar): suppress shrink warnings for consumers#685
dowdiness merged 3 commits into
mainfrom
fix/suppress-grammar-shrink-warnings

Conversation

@dowdiness

@dowdiness dowdiness commented Jul 11, 2026

Copy link
Copy Markdown
Owner

Summary

Suppress the unused_value and unused variable warnings from the GrammarIr QuickCheck Shrink implementations.

Context

Canopy's vendored-check promotes non-vendored warnings to errors. After the GrammarIr shrinker landed, Canopy's Loom submodule job failed on the property-test package even though Loom's own CI passed.

The implementations are intentionally test-only; package-level suppression keeps the property tests available to downstream workspaces that enable warning-as-error checks.

Verification

  • moon check
  • moon test -p dowdiness/loom/grammar --target wasm-gc (53 passed)

Summary by CodeRabbit

  • Chores
    • Updated warning handling in grammar property tests to suppress selected warnings.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b9a74a6a-5479-4daa-9a4c-b0686ac012cf

📥 Commits

Reviewing files that changed from the base of the PR and between 6f40002 and d545e67.

📒 Files selected for processing (1)
  • loom/grammar/grammar_ir_properties_wbtest.mbt

📝 Walkthrough

Walkthrough

Added three #warnings("-1-2") directives before grammar expression and type shrinker definitions. No logic, tests, or public APIs were changed.

Changes

Grammar shrinker warnings

Layer / File(s) Summary
Suppress shrinker warnings
loom/grammar/grammar_ir_properties_wbtest.mbt
Warning suppression directives were added before shrink_expr and the GrammarIr and GrammarWithTokens shrink implementations.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately describes the warning-suppression change.
Description check ✅ Passed The summary, context, and verification are provided, but the template's checklist section is missing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/suppress-grammar-shrink-warnings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dowdiness dowdiness merged commit 023005f into main Jul 11, 2026
38 checks passed
@dowdiness dowdiness deleted the fix/suppress-grammar-shrink-warnings branch July 11, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant