Small refactor to have rows and columns that rotate#2
Open
kevbite wants to merge 1 commit into
Open
Conversation
pgillett
reviewed
Aug 16, 2020
| var right = Right.WithLeftColumn(Top.GetBottomRow().Rotate(Rotation.Clockwise)); | ||
|
|
||
| var top = Top.WithBottomRow(Left.BottomRight, Left.MiddleRight, Left.TopRight); | ||
| var top = Top.WithBottomRow(Left.GetRightColumn().Rotate(Rotation.Clockwise)); |
There was a problem hiding this comment.
Is this column upside down? Just comparing to bottom which the original code pulls in the opposite order
Member
Author
There was a problem hiding this comment.
Oddly I thought that as when I first changed around the code the tests failed... so then I convinced myself that I was rotating it wrong. 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.