Skip to content

Clean up unused parameter and stray escape in upload template #5242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LoopedBard3 merged 1 commit into from
Jun 12, 2026
Merged

Clean up unused parameter and stray escape in upload template #5242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/pipelines/templates/upload-build-artifacts-job.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ parameters:
jobs:
- ${{ each artifact in parameters.artifacts }}:
- job: UploadBuildArtifact_${{ artifact.artifactName }}
displayName: 'Upload Build Artifact ${{ artifact.artifactName }}\'
displayName: 'Upload Build Artifact ${{ artifact.artifactName }}'
condition: eq(stageDependencies.Build.${{ parameters.dependencyJobName }}.result, 'Succeeded')
steps:
- checkout: none
Expand Down
1 change: 0 additions & 1 deletion eng/pipelines/upload-build-artifacts-jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ parameters:
runtimeRepoAlias: runtime
performanceRepoAlias: self
buildType: []
mauiFramework: ''

@DrewScoggins DrewScoggins Jun 12, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this not used anywhere, because we got rid of the maui builds?

@LoopedBard3 LoopedBard3 Jun 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moreso we are not currently passing it through when we upload the artifacts themselves. This is definitely something we can improve on as I think the builds for mauiFramework are likely not running latest, but we will also need to think about how that affects our storage pathing and flow for the BCS.

@LoopedBard3 LoopedBard3 Jun 12, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still used in the actual build steps IIRC, this is just the artifact uploading.


jobs:
- ${{ if containsValue(parameters.buildType, 'coreclr_arm64_linux') }}:
Expand Down
Loading