Skip to content

LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260508054654533 to main#25372

Open
csigs wants to merge 1 commit intomainfrom
lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260508054654533
Open

LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260508054654533 to main#25372
csigs wants to merge 1 commit intomainfrom
lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260508054654533

Conversation

@csigs
Copy link
Copy Markdown
Member

@csigs csigs commented May 8, 2026

LEGO: Pull request from lego/hb_5df43909-4a19-4f55-bc3f-9ea8fccf3c82_20260508054654533 to main with localized lcls

Copilot AI review requested due to automatic review settings May 8, 2026 05:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates mtouch localization resources by adding translations for newly introduced error messages (MX2254–MX2257) in supported .lcl files, ensuring these diagnostics are properly localized.

Changes:

  • Added MX2254MX2257 localized strings for es, de, and zh-Hant mtouch Errors.resx.lcl resources.
  • Included translations for messages related to unsupported primitive field types and non-inlined Dlfcn patterns / IL sequences.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
macios/Localize/loc/zh-Hant/macios/tools/mtouch/Errors.resx.lcl Adds zh-Hant translations for MX2254–MX2257 mtouch error messages.
macios/Localize/loc/es/macios/tools/mtouch/Errors.resx.lcl Adds Spanish translations for MX2254–MX2257 mtouch error messages.
macios/Localize/loc/de/macios/tools/mtouch/Errors.resx.lcl Adds German translations for MX2254–MX2257 mtouch error messages.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #81d7cca] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 81d7ccaa1894c69e27726ffdc44f55830eb8bf88 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #81d7cca] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 81d7ccaa1894c69e27726ffdc44f55830eb8bf88 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne enabled auto-merge (squash) May 8, 2026 11:27
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #81d7cca] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 81d7ccaa1894c69e27726ffdc44f55830eb8bf88 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🔥 Failed to compare API and create generator diff 🔥

Failed to run apidiff

Pipeline on Agent
Hash: 81d7ccaa1894c69e27726ffdc44f55830eb8bf88 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🔥 [CI Build #81d7cca] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

1 tests crashed, 0 tests failed, 172 tests passed.

Failures

❌ windows tests

🔥 Failed catastrophically on VSTS: test results - windows (no summary found).

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. (⚠️ Html Report Publish failed ⚠️) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. (⚠️ Html Report Publish failed ⚠️) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. (⚠️ Html Report Publish failed ⚠️) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 16 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 18 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 16 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 81d7ccaa1894c69e27726ffdc44f55830eb8bf88 [PR build]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants