[github] Fix agentic workflows based on gh-aw guide#25364
Open
rolfbjarne wants to merge 1 commit intomainfrom
Open
[github] Fix agentic workflows based on gh-aw guide#25364rolfbjarne wants to merge 1 commit intomainfrom
rolfbjarne wants to merge 1 commit intomainfrom
Conversation
I asked Copilot to review our agentic workflows according to https://github.com/dotnet/vitals/blob/main/.agents/skills/gh-aw-guide/SKILL.md, and this is what it came up with: * Fix 'maintainer' → 'maintain' (correct GitHub role name) * Change min-integrity from 'none' to 'approved' for both workflows (safer default for public repos, prevents XPIA from untrusted content) * Add concurrency groups (cancel-in-progress: false for slash_command, true for schedule/dispatch) * Add supersede-older-reviews: true on reviewer (auto-dismiss stale REQUEST_CHANGES reviews) * Use fuzzy schedule 'daily' instead of fixed cron for code-radiator * Add target: "*" on add-comment/add-labels for code-radiator (no triggering PR context on schedule/dispatch) * Recompile lock files Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository’s GitHub Agentic Workflows (gh-aw) configurations for the PR reviewer and Code Radiator automation to align with the referenced gh-aw guide, tightening security defaults and improving run behavior.
Changes:
- Corrects the GitHub permission role name from
maintainertomaintain. - Tightens GitHub tool integrity filtering (
min-integrity: approved) and adjusts safe-outputs behavior (including auto-superseding stale “REQUEST_CHANGES” reviews for the reviewer workflow). - Adds concurrency controls and updates Code Radiator scheduling to a “daily (scattered)” schedule; recompiles the generated lock workflows accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/macios-reviewer.md | Updates gh-aw frontmatter: role name fix, adds concurrency, switches min-integrity to approved, and enables superseding older reviews. |
| .github/workflows/macios-reviewer.lock.yml | Recompiled lock workflow reflecting the updated reviewer frontmatter settings (integrity filter, concurrency, supersede behavior, roles). |
| .github/workflows/code-radiator.md | Updates gh-aw frontmatter: daily schedule, role name fix, adds concurrency, switches min-integrity to approved, and sets wildcard targets for comment/label safe-outputs. |
| .github/workflows/code-radiator.lock.yml | Recompiled lock workflow reflecting the updated Code Radiator frontmatter settings (schedule, integrity filter, concurrency, safe-outputs targets, roles). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I asked Copilot to review our agentic workflows according to https://github.com/dotnet/vitals/blob/main/.agents/skills/gh-aw-guide/SKILL.md,
and this is what it came up with:
for public repos, prevents XPIA from untrusted content)
schedule/dispatch)
reviews)
context on schedule/dispatch)