Skip to content

Correct WPF Popup article: remove Expander and tighten popup-implementing controls section#2234

Open
Copilot wants to merge 4 commits intomainfrom
copilot/update-popup-controls-description
Open

Correct WPF Popup article: remove Expander and tighten popup-implementing controls section#2234
Copilot wants to merge 4 commits intomainfrom
copilot/update-popup-controls-description

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 8, 2026

The WPF Popup article listed Expander as a control that implements a popup, which is incorrect. This update also restructures the section text so each listed control directly explains how it uses a popup without redundant API repetition.

  • Scope

    • Updated dotnet-desktop-guide/wpf/controls/popup.md in Controls that implement a Popup.
  • Content corrections

    • Removed Expander from the popup-implementing controls list.
    • Kept the list to actual popup-backed controls: ToolTip, ContextMenu, and ComboBox.
  • Section clarity improvements

    • Rewrote each bullet to:
      • Start with a bold xref.
      • Follow with a single sentence describing popup behavior for that control.
      • Keep the article link for further reading.
    • Removed duplicate xref mentions within bullet descriptions.
- **<xref:System.Windows.Controls.ContextMenu>**. Uses a popup to show command options for an element, usually when users right-click. For more information, see [ContextMenu](contextmenu.md).

Internal previews

📄 File 🔗 Preview link
dotnet-desktop-guide/wpf/controls/popup.md dotnet-desktop-guide/wpf/controls/popup

Copilot AI and others added 2 commits May 8, 2026 17:27
Copilot AI changed the title [WIP] Fix documentation to exclude Expander from Popup controls Correct WPF Popup article: remove Expander and tighten popup-implementing controls section May 8, 2026
Copilot finished work on behalf of adegeo May 8, 2026 17:29
Copilot AI requested a review from adegeo May 8, 2026 17:29
@adegeo adegeo marked this pull request as ready for review May 8, 2026 17:30
Copilot AI review requested due to automatic review settings May 8, 2026 17:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request corrects the WPF Popup documentation by removing an incorrectly listed control and tightening the “Controls that implement a Popup” section so each listed control clearly describes its popup behavior.

Changes:

  • Removed Expander from the list of controls that implement a popup.
  • Rewrote the remaining bullets (ToolTip, ContextMenu, and ComboBox) to describe how each uses a popup while avoiding repeated API mentions.
  • Added/standardized “For more information” links for each listed control.

Comment thread dotnet-desktop-guide/wpf/controls/popup.md
@adegeo adegeo requested a review from gewarren May 8, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Controls that implement a Popup" - should not include Expander

4 participants