Correct WPF Popup article: remove Expander and tighten popup-implementing controls section#2234
Open
Correct WPF Popup article: remove Expander and tighten popup-implementing controls section#2234
Conversation
Agent-Logs-Url: https://github.com/dotnet/docs-desktop/sessions/59b38ee8-b434-4be8-a1d7-d7125c1bb33f Co-authored-by: adegeo <67293991+adegeo@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/docs-desktop/sessions/59b38ee8-b434-4be8-a1d7-d7125c1bb33f Co-authored-by: adegeo <67293991+adegeo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix documentation to exclude Expander from Popup controls
Correct WPF Popup article: remove Expander and tighten popup-implementing controls section
May 8, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request corrects the WPF Popup documentation by removing an incorrectly listed control and tightening the “Controls that implement a Popup” section so each listed control clearly describes its popup behavior.
Changes:
- Removed
Expanderfrom the list of controls that implement a popup. - Rewrote the remaining bullets (ToolTip, ContextMenu, and ComboBox) to describe how each uses a popup while avoiding repeated API mentions.
- Added/standardized “For more information” links for each listed control.
gewarren
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WPF Popup article listed
Expanderas a control that implements a popup, which is incorrect. This update also restructures the section text so each listed control directly explains how it uses a popup without redundant API repetition.Scope
dotnet-desktop-guide/wpf/controls/popup.mdin Controls that implement a Popup.Content corrections
Expanderfrom the popup-implementing controls list.ToolTip,ContextMenu, andComboBox.Section clarity improvements
Internal previews