Skip to content

Add API 37 (CinnamonBun) to KnownVersions#357

Merged
jonathanpeppers merged 1 commit intomainfrom
jonathanpeppers/add-api-37-known-version
May 6, 2026
Merged

Add API 37 (CinnamonBun) to KnownVersions#357
jonathanpeppers merged 1 commit intomainfrom
jonathanpeppers/add-api-37-known-version

Conversation

@jonathanpeppers
Copy link
Copy Markdown
Member

Add AndroidVersion entry for API level 37.0 (framework v17.0, codename CinnamonBun) to the KnownVersions table.

This is needed for dotnet/android PR dotnet/android#11254 which makes net11.0-android37 the default target framework. Without this entry, GetIdFromApiLevel(37), GetFrameworkVersionFromApiLevel(37), etc. don't resolve correctly when AndroidApiInfo.xml is not loaded.

Add AndroidVersion entry for API level 37.0 (framework v17.0,
codename CinnamonBun) so that GetIdFromApiLevel(37),
GetFrameworkVersionFromApiLevel(37), etc. resolve correctly
as a fallback when AndroidApiInfo.xml is not loaded.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 5, 2026 20:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a KnownVersions fallback entry for Android API level 37 so AndroidVersions can resolve API/TFM mappings even when AndroidApiInfo.xml isn’t available (as needed for the net11.0-android37 defaulting work in dotnet/android).

Changes:

  • Add a KnownVersions entry for API 37 / OS version 17.0.
  • Add alternate IDs for the API 37 entry (CinnamonBun, Cinnamon Bun) to improve ID-based lookup.

Comment thread src/Xamarin.Android.Tools.AndroidSdk/AndroidVersions.cs
new AndroidVersion (new Version ("36.1"), "16.0") {
AlternateIds = new[]{ "Canary" },
},
new AndroidVersion (new Version ("37.0"), "17.0") {
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is actually 37.0 on purpose. Google even made it platforms/37.0/android.jar.

@jonathanpeppers jonathanpeppers added the ready-to-review This PR is ready to review/merge. label May 5, 2026
@jonathanpeppers jonathanpeppers merged commit 310b3e9 into main May 6, 2026
6 checks passed
@jonathanpeppers jonathanpeppers deleted the jonathanpeppers/add-api-37-known-version branch May 6, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-review This PR is ready to review/merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants