This repository was archived by the owner on Aug 3, 2021. It is now read-only.
Changes to ensure that the config file is read only once.#111
Open
gabbydotCMS wants to merge 2 commits into
Open
Changes to ensure that the config file is read only once.#111gabbydotCMS wants to merge 2 commits into
gabbydotCMS wants to merge 2 commits into
Conversation
jdotcms
reviewed
Aug 13, 2018
| public static final String DEFAULT_SAML_CONFIG = "defaultSamlConfig"; | ||
| public static final String DISABLE_SAML_SITES = "disabledSamlSites"; | ||
| // Start with TRUE to get at least on read. | ||
| private static Boolean samlConfigured = Boolean.TRUE; |
Contributor
There was a problem hiding this comment.
if these variables are share, they should be mark as a "volatile"
There was a problem hiding this comment.
@jdotcms @gabbydotCMS Would you like us to mark these as volatile?
Contributor
There was a problem hiding this comment.
I think AtomicBoolean would be more accurate for them
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes related to issue #109