fix: revert to_email/to_name EmailJS stopgap - #7
Merged
Conversation
Audit ranks changes by value to visitors and records four verified P0s: contact form unconfigured in the Pages build, Substack 403 from Actions hiding the Writing section, a keyword-matcher assistant, and the default 404 for pre-redesign URLs. Each plan in docs/plans/ is self-contained.
This reverts commit 31acb29.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts commit
31acb29now that the underlying issue is fixed at the source: the EmailJS template's "To email" field is hard-coded to Dom's address (dashboard change, confirmed done).That commit was a same-day stopgap after #4 — removing
to_name/to_emailhad made every contact-form send 422 with "recipients address is empty" because the template still expected{{to_email}}. Restoring those params routed mail to the sender instead of Dom until the template could be fixed properly. With the template now hard-coded, the params are dead weight (the template's fixed value wins over anything passed insend()), so this cleans them back out per the plan's original intent.Test plan
npx tsc --noEmitcleannpm test -- --run— 27 unit tests passnpm run buildsucceedslib/services/emailjs.ts— matches exactlyTravelMap.tsxlint errors seen innpm run lintare unrelated and already fixed on the separatefeat/travel-scrubber-touchbranch (not yet merged), not introduced here🤖 Generated with Claude Code
https://claude.ai/code/session_01TUH1L7Q2FfGYa8dS7Lqvtz