Skip to content

fix(jats): preserve nested list structure in list items#3619

Open
aaarif796 wants to merge 6 commits into
docling-project:mainfrom
aaarif796:test/jats-nested-lists
Open

fix(jats): preserve nested list structure in list items#3619
aaarif796 wants to merge 6 commits into
docling-project:mainfrom
aaarif796:test/jats-nested-lists

Conversation

@aaarif796

@aaarif796 aaarif796 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Issue resolved by this Pull Request:

Summary

  • preserve nested JATS list structure inside list-item
  • avoid flattening nested list content into parent list items
  • add a regression test covering nested lists

Checklist:

  • Tests have been added.
  • Documentation has been updated, if necessary.
  • Examples have been added, if necessary.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

DCO Check Passed

Thanks @aaarif796, all your commits are properly signed off. 🎉

@mergify

mergify Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 Merge protection satisfied — ready to merge.

Show 1 satisfied protection

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

Ansari Mohammad added 3 commits June 16, 2026 13:08
Signed-off-by: Ansari Mohammad <ansari.mohammad@quadratyx.com>
Signed-off-by: Ansari Mohammad <ansari.mohammad@quadratyx.com>
Signed-off-by: Ansari Mohammad <ansari.mohammad@quadratyx.com>
@aaarif796 aaarif796 force-pushed the test/jats-nested-lists branch from e589b1b to ab8a52e Compare June 16, 2026 07:38
@aaarif796 aaarif796 changed the title Test/jats nested lists fix(jats): preserve nested list structure in list items Jun 16, 2026
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ceberam

ceberam commented Jun 16, 2026

Copy link
Copy Markdown
Member

Thanks @aaarif796 for opening this PR. Could you please:

  • Remove the text Resolves #3583, since there are other aspects in the issue that are not addressed in this PR. Otherwise the issue will be automatically closed when we merge your PR.
  • Drop a line in the original issue saying you'd like to contribute to this task. We can then put you as assignee and other potential contributors will know that someone else is already looking at it.
  • Request a review once you consider that the PR is completed.

@aaarif796

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback @ceberam . I've removed the issue-closing reference and added a comment on issue #3583 indicating I'd like to continue working on the remaining list-related tasks. The PR is ready for review.

@PeterStaar-IBM

Copy link
Copy Markdown
Member

@aaarif796 can you fix the merge conflicts? then we can merge this in.

@PeterStaar-IBM PeterStaar-IBM self-requested a review June 29, 2026 03:46
Signed-off-by: aaarif796 <48153674+aaarif796@users.noreply.github.com>
@PeterStaar-IBM

Copy link
Copy Markdown
Member

@ceberam Are you good with this PR?

@PeterStaar-IBM

Copy link
Copy Markdown
Member

@aaarif796 Seems you broke the unit-tests and linting.

@aaarif796

Copy link
Copy Markdown
Contributor Author

@aaarif796 Seems you broke the unit-tests and linting.

Hi @PeterStaar-IBM,

Thanks for pointing this out.

Before pushing the latest changes, I ran the unit tests along with ruff check and ruff format, and everything passed locally. I'm investigating why the GitHub CI is reporting linting and unit test failures, as I haven't been able to reproduce them on my machine yet.

If I'm missing something specific in the CI logs, I'd appreciate any guidance. Thanks!

aaarif796 added 2 commits July 1, 2026 10:35
Removed the convert_jats_body function and its related logic. Added assertions to test the export of nested items to markdown.

Signed-off-by: aaarif796 <48153674+aaarif796@users.noreply.github.com>
Signed-off-by: aaarif796 <48153674+aaarif796@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants