fix(jats): preserve nested list structure in list items#3619
Conversation
|
✅ DCO Check Passed Thanks @aaarif796, all your commits are properly signed off. 🎉 |
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Signed-off-by: Ansari Mohammad <ansari.mohammad@quadratyx.com>
Signed-off-by: Ansari Mohammad <ansari.mohammad@quadratyx.com>
Signed-off-by: Ansari Mohammad <ansari.mohammad@quadratyx.com>
e589b1b to
ab8a52e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Thanks @aaarif796 for opening this PR. Could you please:
|
|
@aaarif796 can you fix the merge conflicts? then we can merge this in. |
Signed-off-by: aaarif796 <48153674+aaarif796@users.noreply.github.com>
|
@ceberam Are you good with this PR? |
|
@aaarif796 Seems you broke the unit-tests and linting. |
Hi @PeterStaar-IBM, Thanks for pointing this out. Before pushing the latest changes, I ran the unit tests along with If I'm missing something specific in the CI logs, I'd appreciate any guidance. Thanks! |
Removed the convert_jats_body function and its related logic. Added assertions to test the export of nested items to markdown. Signed-off-by: aaarif796 <48153674+aaarif796@users.noreply.github.com>
Signed-off-by: aaarif796 <48153674+aaarif796@users.noreply.github.com>
Issue resolved by this Pull Request:
Summary
list-itemChecklist: