chore(document): register the Box Note mime type#668
Open
pablopupo wants to merge 1 commit into
Open
Conversation
Contributor
|
✅ DCO Check Passed Thanks @pablopupo, all your commits are properly signed off. 🎉 |
3 tasks
Contributor
Merge Protections🟢 Merge protection satisfied — ready to merge. Show 1 satisfied protection🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ceberam
requested changes
Jun 30, 2026
Member
There was a problem hiding this comment.
Thanks @pablopupo for submitting this PR so quickly.
Since you're touching the _extra_mimetypes list and to keep things tidy, would you mind sorting it in alphabetical order?
For this small change, I would rather give another commit type like chore.
Author
|
Done! |
pablopupo
force-pushed
the
feat/boxnote-mimetype
branch
from
a8d2797 to
c0f14e3
Compare
DocumentOrigin rejects application/vnd.box.boxnote because it isn't in Python's mimetypes registry, so the Box Note backend in docling (docling-project/docling#3722) falls back to application/json. This registers it in _extra_mimetypes so the backend can use the correct mime. The list is also sorted alphabetically now. Signed-off-by: pablopupo <145598901+pablopupo@users.noreply.github.com>
pablopupo
force-pushed
the
feat/boxnote-mimetype
branch
from
c0f14e3 to
a980141
Compare
pablopupo
changed the title
ceberam
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DocumentOriginrejectsapplication/vnd.box.boxnotebecause it isn't in Python'smimetypesregistry, so the Box Note backend in docling (docling-project/docling#3722) falls back toapplication/json. This registers it in_extra_mimetypes, alongside the other vendor types, so the backend can use the correct mime.Per @ceberam's review on that PR.