Fix/postgres infinity - #127
Merged
Merged
Conversation
PostgreSQL 14 added binary markers for positive and negative numeric infinity. The old encoder handled zero and NaN, but infinity reached an unreachable branch and panicked in the caller. Teach the shared Fraction and Decimal codec to read and write both markers. The regression tests cover constructors, division by zero, and appending to an existing query buffer while keeping finite and NaN behaviour unchanged. Refs #123
Document that numeric infinities require PostgreSQL 14 or newer and an unconstrained NUMERIC column. Older servers and constrained numeric columns reject those values. The README, crate documentation, and unreleased changelog now describe the same boundary so users do not have to infer it from the wire-format code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.