Fix/zero denominator parsing - #125
Merged
Merged
Conversation
String parsing built num-rational ratios directly, so inputs such as 1/0 reached Ratio::new and panicked before FromStr could return. Parsed values now use the same signed constructor as GenericFraction::new. Non-zero numerators become signed infinity, zero over zero becomes NaN, and ordinary fractions are still reduced. Regression tests cover Fraction, small generic values, Decimal, and the optional Unicode parser.
Parsing now follows the same rule as GenericFraction::new. The docs explain that non-zero values over zero become signed infinity and zero over zero becomes NaN, including Decimal and optional Unicode parsing. The changelog records the fix for the next release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.