Improve how DNS records are displayed#2
Open
sbastn wants to merge 1 commit into
Open
Conversation
Member
|
Can you explain why you are branching out table with unix and table with other? What issue did you experience specifically, and in which OS? |
Member
Author
|
I split it because terminal width detection here uses a Unix-specific call to get the window size of the terminal. It uses the golang.org/x/sys/unix package. That works on macOS/Linux, but it is not portable to Windows or other non-Unix targets, so the other file is just a build-safe fallback. I didn’t hit an OS-specific runtime bug. The issue was portability: without the split, the output package would stop compiling cleanly outside Unix-like systems. I developed/tested this on macOS. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the formatting of the DNS records:
👀 Preview
Before
After
On a different resolution (smaller size):

Summary
QA
make buildbin/dnsimple records list jacegu.com