Skip to content

Documented how media and network payload is calculated#619

Open
sviengkhou wants to merge 2 commits into
dmf-mxl:mainfrom
sviengkhou:feature/FabricsBandwidthDocumentation
Open

Documented how media and network payload is calculated#619
sviengkhou wants to merge 2 commits into
dmf-mxl:mainfrom
sviengkhou:feature/FabricsBandwidthDocumentation

Conversation

@sviengkhou

Copy link
Copy Markdown

Details

Documented how media and network payload is calculated.
Separation of Media and Network overhead
Initially addresses RoCE/RDMA
Example:
assume IPV4, No VLAN tagging
All numbers are appoximation

Backport requirements

Should be part of V1.1

Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>

@pedro-alves-ferreira pedro-alves-ferreira left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread docs/FabricsBandwidth.md
$$

Equivalent integer form used in MXL implementation:
- `v210LineBytes = ((w + 47) / 48) * 128`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlefebvre1 It's per line, so I think the original is correct.

Comment thread docs/FabricsBandwidth.md Outdated
- `frame_width = 1920`
- `frame_height = 1080`
- `frame_rate = 25`
- `mtu = 1400` (transport assumption used in this document)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for RoCEv2 it should be one of 1024,2048 or 4096
same comment for all other examples

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will make the changes

Comment thread docs/FabricsBandwidth.md Outdated
- `providerWireOverheadBytes = 82`

Provenance of `providerWireOverheadBytes`:
- This constant is a modeled, per-packet on-wire cost for the `rdma_rocev2` provider profile.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not talking about provider profiles anywhere else. So maybe we could reword this to a more informal:

Suggested change
- This constant is a modeled, per-packet on-wire cost for the `rdma_rocev2` provider profile.
- This constant is a modeled, per-packet on-wire cost for the verbs provider using RoCEv2.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will use suggestion

Comment thread docs/FabricsBandwidth.md Outdated
Interpretation:
- Use `providerMtuOverheadBytes` to compute payload capacity per packet (`mtu - overhead`).
- Use `providerWireOverheadBytes` to compute true wire-rate amplification (`packetsPerSecond * overhead`).
- Keeping both constants separate avoids mixing MTU-budget math and on-wire transmission-time math.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this remark is not really necessary 😄

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will remove the last bullet

Comment thread docs/FabricsBandwidth.md
---

## Practical Notes
- For audio, wire bandwidth is ptime-sensitive because packet count and per-packet overhead change with ptime, even when raw media byte rate is constant.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should explain what ptime means in our context (I guess you mean the commit batch size?), because ptime sounds a lot like PTP, but it has nothing to do with that.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about 'a audio grain duration is the semantical equivalent to what 2110 refers as ptime'?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could add "packet time", just to clarify: 'a audio grain duration is the semantical equivalent to what 2110 refers as ptime (packet time)'.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants