Feature/a more resource hungry sink application#502
Conversation
|
Maybe we could also use |
|
TSC
|
63c67ab to
d0a321e
Compare
KimonHoffmann
left a comment
KimonHoffmann
left a comment
There was a problem hiding this comment.
Thank you for this contribution, a small MV is surely a good demo use-case!
A few small mostly stylistic suggestions from my side.
KimonHoffmann
left a comment
KimonHoffmann
left a comment
There was a problem hiding this comment.
Thank you for addressing the changes!
I resolved all the ones that have been taken care of and readied a few that got dropped due to the code having changed.
|
@KimonHoffmann Hopefully, I've not missed any of your comments. Thank you for the review. |
KimonHoffmann
left a comment
KimonHoffmann
left a comment
There was a problem hiding this comment.
Thank you!
All changes have been addressed now, as far as I'm concerned. One last small comment about one of the changes, though.
| while (::gst_iterator_next(padIter, &item) == GST_ITERATOR_OK) | ||
| { | ||
| GstPad* pad = static_cast<GstPad*>(::g_value_get_object(&item)); | ||
| auto const* pad = static_cast<GstPad*>(::g_value_get_object(&item)); |
There was a problem hiding this comment.
auto const* makes the result type slightly different than the type of right hand side expression, because it const-qualifies the pointer rather than the variable, so it should rather be one of the following:
auto constauto* const, or (if you want the keep the const-qualified pointer)auto const* const.
d420588 to
ae6d96f
Compare
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net> Signed-off-by: Michael Lefebvre <michael.lefebvre@riedel.net>
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
Signed-off-by: Sithideth Viengkhou (Riedel) <sithideth.viengkhou@riedel.net>
ae6d96f to
80bdc53
Compare
6 participants
A test app that consumed more resource was required for JT-DMF activity
Create a version of the GSTREAMER mxl-gst-sink application that can read from 4 source and create a mosaic.
Maybe this would benefit the MXL community.