Use a switch instead of a global dictionary for primitiveTypeInfo#6015
Merged
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
quickfur
reviewed
Jan 8, 2018
quickfur
left a comment
quickfur
left a comment
Member
There was a problem hiding this comment.
LGTM.
Only question is, how is typeid(...) implemented? Just wondering if the reason for the global hash is to prevent excessive recomputation, if typeid(...) has a complex implementation. But if it's just returning a pre-made object, then it's probably OK.
quickfur
approved these changes
Jan 8, 2018
quickfur
left a comment
quickfur
left a comment
Member
There was a problem hiding this comment.
Actually, just checked the disassembly. It does just return a static object. So we're good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discovered while working on #6014