Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.

Remove pointless version(unittest)#2056

Merged
wilzbach merged 2 commits into
dlang:masterfrom
wilzbach:pointless-version
Jan 24, 2018
Merged

Remove pointless version(unittest)#2056
wilzbach merged 2 commits into
dlang:masterfrom
wilzbach:pointless-version

Conversation

@wilzbach

Copy link
Copy Markdown
Contributor

No description provided.

@wilzbach wilzbach added the Trivial typos, formatting, comments label Jan 23, 2018
@schveiguy

Copy link
Copy Markdown
Member

There's another one a few more lines above.

@dlang-bot

Copy link
Copy Markdown

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@schveiguy

Copy link
Copy Markdown
Member

FIFY :)

@schveiguy

Copy link
Copy Markdown
Member

Why is circleci failing with that core.time test? Seems very odd.

@wilzbach

Copy link
Copy Markdown
Contributor Author

Thanks! See #2048

@schveiguy

Copy link
Copy Markdown
Member

See #2048

Whew! I thought maybe the version(unittest) removal was causing it 😄 . Still very strange.

@PetarKirov PetarKirov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wilzbach Feel free to force merge

@wilzbach wilzbach merged commit a66f9fa into dlang:master Jan 24, 2018
@wilzbach wilzbach deleted the pointless-version branch January 24, 2018 07:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants