-binメタデータ送信をパディングなしbase64にする - #27
Merged
Merged
Conversation
PROTOCOL-HTTP2はBinary-Headerのbase64について「送信はパディングなしを 推奨」と定めており、公式実装(C-core/grpc-go)もパディングなしで送出する。 append_custom_request_header_valueでphp_base64_encode後に末尾の'='を 切り詰め、1/2/3バイト境界のワイヤ値をトレースで検証するphptを追加。 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
dkkoma
added a commit
that referenced
this pull request
Jul 14, 2026
- PR #26/#27/#28/#29 でマージ済みの issue（goaway transparent retry / bin metadata unpadded base64 / status taxonomy / encoding flag=0 / deadline RST_STREAM）を Status: Closed にして docs/issues/closed/ へ移動 - PR #29 レビューサイクル（pass 4〜11）の記録 30 ファイルを docs/reviews/issues/ に追加 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/issues/open/2026-07-08-bin-metadata-unpadded-base64.mdの修正。php_base64_encodeのパディング付き出力をそのまま送出していた。append_custom_request_header_value(src/transport.c)でエンコード後に末尾=を切り詰める。Test plan
tests/phpt/032-bin-metadata-unpadded-base64.phpt: 1/2/3 バイト境界の値(パディング 2/1/0 個)で、GRPC_LITE_TRACE_FILEのwire.request_headerレコードからワイヤ上の値に=が含まれないことを検証し、fixture サーバーのエコーで round-trip も確認。tools/test/check-phpt.sh: 17/17 PASS。tests/Integration/MetadataCompatibilityTest.php: 4 tests / 18 assertions OK。🤖 Generated with Claude Code