Pause button added#74
Open
raj10071997 wants to merge 2 commits into
Open
Conversation
Owner
|
this is awesome, thanks! sorry, I don't have my laptop at the moment so can't test the changes. was wondering if you could modify the changes for code clarity before we test and merge, (ie: DBHelperItem2 -> DBHelperPausedItem?, addRecording2 -> addPausedRecording?) etc. also if possible remove any hard coded strings, such as RecordingService.java line 196 - "hello_recording". (also probably use a clearer string like "paused_recording"). in startAppendingAudio method in RecordingService, the isAudio boolean is unnecessary. if you could add some comments in this method as well it would be really helpful, as it's a bit hard to understand. |
Author
|
I have added the required comments and the isAudio boolean was unnecessary so I removed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used this library https://github.com/sannies/mp4parser for adding the functionality of pause. I also made a second table to store the files created in when you want to use pause button and then taking the absolute path of those files from the second table and using this library to merge those audio file and create a new file and then storing that new file in table one. Then i delete all the files from table 2.