Skip to content

Pause button added#74

Open
raj10071997 wants to merge 2 commits into
dkim0419:masterfrom
raj10071997:test
Open

Pause button added#74
raj10071997 wants to merge 2 commits into
dkim0419:masterfrom
raj10071997:test

Conversation

@raj10071997

Copy link
Copy Markdown

I used this library https://github.com/sannies/mp4parser for adding the functionality of pause. I also made a second table to store the files created in when you want to use pause button and then taking the absolute path of those files from the second table and using this library to merge those audio file and create a new file and then storing that new file in table one. Then i delete all the files from table 2.

@dkim0419

Copy link
Copy Markdown
Owner

this is awesome, thanks! sorry, I don't have my laptop at the moment so can't test the changes. was wondering if you could modify the changes for code clarity before we test and merge, (ie: DBHelperItem2 -> DBHelperPausedItem?, addRecording2 -> addPausedRecording?) etc.

also if possible remove any hard coded strings, such as RecordingService.java line 196 - "hello_recording". (also probably use a clearer string like "paused_recording").

in startAppendingAudio method in RecordingService, the isAudio boolean is unnecessary. if you could add some comments in this method as well it would be really helpful, as it's a bit hard to understand.

@raj10071997

Copy link
Copy Markdown
Author

I have added the required comments and the isAudio boolean was unnecessary so I removed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants