Store recording metadata on the filesystem#59
Conversation
|
@fabianrost84 @stsydow Please review. |
|
Looks good to me but haven't tested or build it yet. |
|
https://github.com/andrewgaul/SoundRecorder/blob/4d761b6aa22b76bf6d59465d63d2dc65ede74823/app/src/main/java/com/danielkim/soundrecorder/RecordingService.java#L114 causes problems when I try to build. Should make use of a timestamp instead, right? |
This removes use of the database and allows media management via USB MTP. Originally written by @stsydow and sourced from stsydow@2b4c02e . Modified by @andrewgaul to remove extraneous changes and rebase onto master. Fixes dkim0419#47.
|
@fabianrost84 Sorry I did not test this after reverting the timestamp commit. The latest commit should fix this. |
|
does this check for cases where there are other files in the parent folder, that aren't mp4's, for example a random jpg? or cases where file formats could be different (ie: some are saved as mp3, some as mp4, etc), could it cause an issue in the future when retrieving metadata? |
|
The only check is to ensure SoundRecorder does not overwrite an existing recording. It parses the recording number to generate the next recording in the sequence, e.g., If we bring back timestamp filenames from #43 we can remove this logic. |
There was a problem hiding this comment.
@gaul you are right , if we support multiple formats we could remove the suffix part of the test.
fixes issue dkim0419#25 * `*.tmp` file is now stored in /storage/emulated/0/Android/data/by.naxa.soundrecorder/cache/SoundRecorder.by/* * new method `createDirectory` is created in `Paths` to create directory * optimized imports
5 participants
This removes use of the database and allows media management via USB
MTP. Originally written by @stsydow and sourced from
stsydow@2b4c02e .
Modified by @andrewgaul to remove extraneous changes and rebase onto
master. Fixes #47.