Suppress errors when reading Git aliases#73
Open
AlexWaygood wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Suppress stderr from the best-effort
git config --get-regexp "^alias\."lookup.The lookup currently runs before every command and ignores Git's exit status. If the shell's current working directory has been deleted, Git emits
fatal: Unable to read current working directory: No such file or directoryeven though alias-tips continues normally and the command may recover, for example by changing to an absolute directory. This was kind-of confusing to me -- something "fatal" happened? But the command I entered into the terminal succeeded and exited with code 0?Because this lookup already treats failure as “no Git aliases”, suppressing its stderr makes the visible behavior consistent with its failure handling.