fix: Migration metrics skipped for configured DBs if if default DB unconfigured#501
Open
OscarVanL wants to merge 1 commit into
Open
Conversation
OscarVanL
marked this pull request as draft
June 4, 2026 10:49
OscarVanL
marked this pull request as ready for review
June 4, 2026 10:49
OscarVanL
force-pushed
the
500/skip-uninitialised-default-database
branch
from
June 4, 2026 10:51
afc1cca to
55ae869
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates ExportMigrations() so migration metrics are exported for non-default database aliases even when the default connection is a dummy database (the DATABASES = {} / dummy-backend case), aligning behavior with the expectation in issue #500.
Changes:
- Adjusted
ExportMigrations()to skip only the dummydefaultconnection rather than returning early for all connections. - Added tests covering
ExportMigrations()behavior for dummy-only, real-only, and mixed dummy+real connection sets.
Show a summary per file
| File | Description |
|---|---|
django_prometheus/migrations.py |
Moves the dummy-DB guard into the per-alias loop so other DB aliases still get migration metrics exported. |
django_prometheus/tests/end2end/testapp/test_migrations.py |
Adds unit-style tests for ExportMigrations() using patched connections and MigrationExecutor. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 1
… legitimate databases Apply Copilot's suggestion Revert "Apply Copilot's suggestion" This reverts commit bca65e2.
OscarVanL
force-pushed
the
500/skip-uninitialised-default-database
branch
from
June 4, 2026 17:08
82aea8f to
1952826
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500