Skip to content

task-observer: deep-review updates from 2026-05-06#10

Open
divad12 wants to merge 1 commit into
masterfrom
task-observer/deep-review-2026-05-06
Open

task-observer: deep-review updates from 2026-05-06#10
divad12 wants to merge 1 commit into
masterfrom
task-observer/deep-review-2026-05-06

Conversation

@divad12
Copy link
Copy Markdown
Owner

@divad12 divad12 commented May 6, 2026

Target

skill: .agents/skills/deep-review/SKILL.md

Observations addressed

  • Observation 5 (journology/log.md): Deep-review finding triage ignored AGENTS.md exclusions → changed: Added inverse de-scope rule to Rule Compliance Audit (Step 1.5): de-scoped capabilities create inadmissibility rules, not just absence-of-violation escalation. Added carve-out to UI reviewer accessibility criteria. Added explicit rule to the Rules section stating de-scoped findings must not be auto-fixed.

Generated by Claude Code

Add the inverse of the violation-escalation rule: when AGENTS.md
explicitly de-scopes a capability (e.g. "No ARIA work yet",
"desktop-only", "no-i18n"), findings targeting that area are
inadmissible and must not be auto-fixed.

Also note de-scoped concern check in the UI reviewer accessibility
criteria so subagents apply the same suppression.
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7909c4c867

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- **If the independent reviewer is unavailable or fails**, proceed with the orchestrator-side reviews. Note which independent reviewer was skipped in the summary.
- **If no frontend files changed**, skip the UI review entirely. Don't mention it in the summary.
- **Respect project conventions.** Check CLAUDE.md for project-specific rules and flag violations.
- **Respect project conventions.** Check CLAUDE.md/AGENTS.md for project-specific rules and flag violations. Apply the inverse equally: if AGENTS.md explicitly de-scopes a capability ("No ARIA/screen reader work yet", "desktop-only", "no-i18n", "single-user"), findings targeting that capability are inadmissible — skip them and do not auto-fix. One-directional calibration (escalating violations without suppressing de-scoped concerns) produces out-of-scope changes the user didn't ask for.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply de-scope carve-out to CLAUDE.md rules too

This new rule makes de-scoped findings inadmissible only when AGENTS.md declares the de-scope, but Step 1 in the same workflow instructs reviewers to derive rules from CLAUDE.md or AGENTS.md. In projects that declare scope limits in CLAUDE.md (or docs it references), reviewers following this text can still raise and auto-fix out-of-scope items, which defeats the purpose of this change. Include CLAUDE.md-sourced de-scopes in the inadmissibility rule so scope suppression is consistent.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants