New API endpoint for registering texture parameters#50
New API endpoint for registering texture parameters#50egorovaanastasiia wants to merge 1 commit into
Conversation
WalkthroughThis PR exposes a new texture parameter registration function across the RenderStream API stack. A new C API function ChangesTexture Parameters Registration API
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CHANGELOG.md`:
- Line 3: Replace the placeholder compatibility token "rXX.x" in the CHANGELOG
entry with the actual disguise designer minimum version (e.g., r3.0 or whatever
the real minimum is) so the support matrix is unambiguous; locate the line
containing the string "Compatible with disguise designer version rXX.x" and
update it to the real version number and, if relevant, adjust the parenthetical
note about RS3.0 to reflect the correct release requirement.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9e42b359-23a8-4eb1-8e6b-8a12fef6c60d
📒 Files selected for processing (3)
CHANGELOG.mdsrc/include/d3renderstream.hsrc/include/renderstream.hpp
| # RS3.0 | ||
|
|
||
| Compatible with disguise designer version r31.1 and above. | ||
| Compatible with disguise designer version rXX.x(need to be updated before releasing RS3.0) and above. |
There was a problem hiding this comment.
Replace the placeholder compatibility version before merge.
Line 3 still uses rXX.x, which makes the support matrix ambiguous for integrators.
Suggested edit
-Compatible with disguise designer version rXX.x(need to be updated before releasing RS3.0) and above.
+Compatible with disguise designer version r<final_version> and above.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| Compatible with disguise designer version rXX.x(need to be updated before releasing RS3.0) and above. | |
| Compatible with disguise designer version r<final_version> and above. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CHANGELOG.md` at line 3, Replace the placeholder compatibility token "rXX.x"
in the CHANGELOG entry with the actual disguise designer minimum version (e.g.,
r3.0 or whatever the real minimum is) so the support matrix is unambiguous;
locate the line containing the string "Compatible with disguise designer version
rXX.x" and update it to the real version number and, if relevant, adjust the
parenthetical note about RS3.0 to reflect the correct release requirement.
DSOF-30790
Related PRs:
d3 - https://github.com/disguise-one/d3/pull/5933/
Plugin - disguise-one/RenderStream-UE#140
Note:
Need to update supporting d3 version info when we release RS3.0
Summary by CodeRabbit
New Features
Documentation