Improve accessibility with semantic HTML and ARIA labels#43
Merged
Conversation
Wrap hero social links in <nav>/<ul>/<li> for semantic list markup, and add unique aria-label to each "View details" button to distinguish links with the same text pointing to different destinations. https://claude.ai/code/session_01McFq4WpibdejyTF9WPHYrv
The image sits next to the visible name, so alt="" is correct per spec. https://claude.ai/code/session_01McFq4WpibdejyTF9WPHYrv
…only alt="" removes the image from the accessibility tree, making aria-labelledby ineffective. aria-labelledby alone is the correct pattern here. https://claude.ai/code/session_01McFq4WpibdejyTF9WPHYrv
…abel aria-label prop forwarding via UButton is unreliable; sr-only text in the slot is guaranteed to reach the DOM and be announced by screen readers. https://claude.ai/code/session_01McFq4WpibdejyTF9WPHYrv
aria-labelledby caused the name to be announced twice. Empty alt correctly marks the image as redundant since the name is already in adjacent text. https://claude.ai/code/session_01McFq4WpibdejyTF9WPHYrv
…alk cards Covers: View details, Demo, Repository in LabCard; View details in LabsTeaser and TalkPreviewCard (speaking listing page and homepage teaser). https://claude.ai/code/session_01McFq4WpibdejyTF9WPHYrv
… markup Mirrors the labs detail page fix; tools skip nav landmarks when checking for redundant links, so this also resolves the back-link redundancy warning. https://claude.ai/code/session_01McFq4WpibdejyTF9WPHYrv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the accessibility of the landing page and lab cards by implementing semantic HTML structures and adding descriptive ARIA labels.
Key Changes
<nav>and<ul>/<li>elements instead of a generic<div>, with an appropriatearia-labelfor screen readersaria-labelto the "View details" button that includes the lab title for better context when using assistive technologiesImplementation Details
https://claude.ai/code/session_01McFq4WpibdejyTF9WPHYrv