chore: dissolve dimos/memory/#2319
Conversation
dimos/memory/ was a misnamed util library plus dead code, colliding with the live memory2/. Relocate the two live pieces and delete the rest: - timeseries base + InMemoryStore -> dimos/utils/timeseries/ - LegacyPickleStore -> dimos/utils/testing/legacy_pickle.py (beside the replay/moment fixtures that wrap it) - delete embedding.py (dead POC superseded by memory2; orphaned blueprint), the unused pickledir/sqlite/postgres timeseries backends, and the orphaned detect.py / fake_zed_module.py modules - regenerate all_blueprints.py (drops the embedding-memory entry) - rewrite all import sites + mock.patch targets; trim test_base.py to the InMemoryStore case memory2/ untouched.
After trimming to the InMemoryStore-only case, temp_dir was unused. Remove the fixture + tempfile import, make the factory no-arg, and drop the param from the parametrized test signatures.
Greptile SummaryThis PR dissolves the
Confidence Score: 5/5Safe to merge — this is a pure structural reorganization with no logic changes. Every dimos.memory.timeseries.* import site was migrated to the new paths and confirmed clean via grep. The deleted files (pickledir.py, postgres.py, sqlite.py, embedding.py, fake_zed_module.py, detect.py) have no remaining callers. The renamed files (base.py, inmemory.py, legacy.py) are functionally identical at their new locations, and the backward-compat shim in replay.py preserves the TimedSensorReplay/SensorReplay/SensorStorage aliases for existing call sites. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
subgraph OLD["dimos/memory/timeseries/ (dissolved)"]
A[base.py]
B[inmemory.py]
C[legacy.py]
D[pickledir.py]
E[postgres.py]
F[sqlite.py]
G[test_base.py]
H[test_legacy.py]
end
subgraph NEW_UTILS["dimos/utils/timeseries/ (new home)"]
A2[base.py]
B2[inmemory.py]
G2[test_base.py]
end
subgraph NEW_TESTING["dimos/utils/testing/ (new home)"]
C2[legacy_pickle.py]
H2[test_legacy.py]
end
subgraph DELETED["Deleted (superseded by memory2)"]
D2[pickledir.py ❌]
E2[postgres.py ❌]
F2[sqlite.py ❌]
end
subgraph ALSO_DELETED["Also deleted (dead code)"]
I[memory/embedding.py ❌]
J[hardware/sensors/fake_zed_module.py ❌]
K[robot/unitree/modular/detect.py ❌]
end
A -->|rename| A2
B -->|rename| B2
C -->|rename + class rename| C2
D -->|deleted| D2
E -->|deleted| E2
F -->|deleted| F2
G -->|rename + updated| G2
H -->|rename| H2
Reviews (3): Last reviewed commit: "Merge branch 'main' into chore/dissolve-..." | Re-trigger Greptile |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
removes old memory dir