feat(features): add the Brecilien portal as a temporary map feature - #67
Open
Maelstromeous wants to merge 2 commits into
Open
feat(features): add the Brecilien portal as a temporary map feature#67Maelstromeous wants to merge 2 commits into
Maelstromeous wants to merge 2 commits into
Conversation
Adds `brazilianPortalPresent`, a boolean node feature that behaves like the crystal creature flag: toggled from the zone's map-features editor, shown as an icon on the node, and summarised in the desktop tray and the mobile sheet with click-to-navigate zone lists. It is transient, so it stays out of the `room_node_memory` allowlist in update_node_positions — the feature exists only while the zone is on the map. Icon lives at web/client/public/images/brazilian-portal.png. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeivNnZKtp2k9qP6byTxF1
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
It is the Roads city Brecilien, not "Brazilian". Renames the feature key, the icon file, the UI labels and the test. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeivNnZKtp2k9qP6byTxF1
Maelstromeous
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
brecilienPortalPresent, a boolean node feature modelled directly on the crystal creature flag.What it does
web/shared/src/types.ts— added toNodeFeaturesand the Zod schema.TOGGLESlist so both boolean features render from one place.room_node_memoryallowlist inupdate_node_positions.ts, so it is never written to memory — the flag lives only while the zone is on the map.Icon
web/client/public/images/brecilien-portal.png, supplied by @Maelstromeous. It is 99×101, smaller than the other feature icons (crystal is 367²), so it looks slightly soft at the 56 px size used in the editor modal. Worth swapping for a larger crop later; nothing else depends on the dimensions.Tests
Full suite green: shared 102, server 346, map-parser 64, client 373.
web/client/test/BrecilienPortalFeature.test.ts(3 tests) covers the node icon rendering with and without the flag, and the modal emittingbrecilienPortalPresent.crystalCreaturePresentand the timed chest.Notes
docs/client.mdupdated for the new summary list.pnpm --filter client lintfails on this branch, but it fails onmaintoo — there is noeslint.config.jsanywhere in the repo and ESLint 9 requires one. Not addressed here.