Skip to content

upgrade Docker client to v29#212

Open
dmke wants to merge 1 commit intomasterfrom
docker-29
Open

upgrade Docker client to v29#212
dmke wants to merge 1 commit intomasterfrom
docker-29

Conversation

@dmke
Copy link
Copy Markdown
Member

@dmke dmke commented Apr 13, 2026

This was a little painful, details here: https://github.com/moby/moby/releases/tag/docker-v29.0.0

Will let this mature a little before merging/releasing.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 79.41%. Comparing base (2e1cb29) to head (4ec70bd).

Files with missing lines Patch % Lines
exec/docker_client.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #212      +/-   ##
==========================================
+ Coverage   79.37%   79.41%   +0.04%     
==========================================
  Files          43       43              
  Lines        1847     1851       +4     
==========================================
+ Hits         1466     1470       +4     
  Misses        310      310              
  Partials       71       71              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Docker client dependency stack to Docker/Moby v29-era packages, updating import paths and API calls to match the new client interfaces.

Changes:

  • Replace github.com/docker/docker usage with github.com/moby/moby/api and github.com/moby/moby/client.
  • Update Docker client calls (e.g., ContainerInspect, ImageList, ContainerCreate, ContainerWait, ContainerStart) to new option/result types.
  • Refresh Go module dependencies (go.mod/go.sum) to reflect the upgraded Docker/Moby packages.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
go.mod Swaps Docker dependency from github.com/docker/docker to github.com/moby/moby/{api,client} and updates indirect requirements accordingly.
go.sum Updates checksums for the new dependency graph after the Docker/Moby v29 upgrade.
exec/docker_in_docker.go Adjusts ContainerInspect call signature and mounts access for the new client result type.
exec/docker_in_docker_test.go Updates mount import path to the new Moby API module.
exec/docker_client.go Migrates Docker client construction and API calls to the new Moby client interfaces/types.
exec/docker_client_test.go Updates mocks and tests to the new Moby client method signatures and return types.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread exec/docker_client.go
Comment on lines 155 to 161
// pull pulls the given image tag. Progress is reported to p, unless
// p is nil.
func (dc *DockerClient) pull(ctx context.Context, tag string, p *progress) error {
r, err := dc.cli.ImagePull(ctx, tag, image.PullOptions{})
r, err := dc.cli.ImagePull(ctx, tag, client.ImagePullOptions{})
if err != nil {
return err
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants