Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #212 +/- ##
==========================================
+ Coverage 79.37% 79.41% +0.04%
==========================================
Files 43 43
Lines 1847 1851 +4
==========================================
+ Hits 1466 1470 +4
Misses 310 310
Partials 71 71 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Docker client dependency stack to Docker/Moby v29-era packages, updating import paths and API calls to match the new client interfaces.
Changes:
- Replace
github.com/docker/dockerusage withgithub.com/moby/moby/apiandgithub.com/moby/moby/client. - Update Docker client calls (e.g.,
ContainerInspect,ImageList,ContainerCreate,ContainerWait,ContainerStart) to new option/result types. - Refresh Go module dependencies (
go.mod/go.sum) to reflect the upgraded Docker/Moby packages.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Swaps Docker dependency from github.com/docker/docker to github.com/moby/moby/{api,client} and updates indirect requirements accordingly. |
| go.sum | Updates checksums for the new dependency graph after the Docker/Moby v29 upgrade. |
| exec/docker_in_docker.go | Adjusts ContainerInspect call signature and mounts access for the new client result type. |
| exec/docker_in_docker_test.go | Updates mount import path to the new Moby API module. |
| exec/docker_client.go | Migrates Docker client construction and API calls to the new Moby client interfaces/types. |
| exec/docker_client_test.go | Updates mocks and tests to the new Moby client method signatures and return types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
155
to
161
| // pull pulls the given image tag. Progress is reported to p, unless | ||
| // p is nil. | ||
| func (dc *DockerClient) pull(ctx context.Context, tag string, p *progress) error { | ||
| r, err := dc.cli.ImagePull(ctx, tag, image.PullOptions{}) | ||
| r, err := dc.cli.ImagePull(ctx, tag, client.ImagePullOptions{}) | ||
| if err != nil { | ||
| return err | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a little painful, details here: https://github.com/moby/moby/releases/tag/docker-v29.0.0
Will let this mature a little before merging/releasing.