Skip to content

fix: write transcript completion marker last - #7

Open
sumajoo wants to merge 1 commit into
digimata:masterfrom
sumajoo:fix/transcript-completion-marker
Open

fix: write transcript completion marker last#7
sumajoo wants to merge 1 commit into
digimata:masterfrom
sumajoo:fix/transcript-completion-marker

Conversation

@sumajoo

@sumajoo sumajoo commented Jul 28, 2026

Copy link
Copy Markdown

Summary

  • write transcript.md before transcript.json
  • keep transcript.json as the final completion marker for a session
  • add a minimal Swift Testing target with a regression test

Why

resumePending() treats the presence of transcript.json as “done”. Previously,
the JSON file was written before the Markdown transcript. If the Markdown write
failed, the JSON marker remained and the session was never retried.

Writing the Markdown artifact first and the JSON marker last preserves the
existing successful output while leaving failed sessions pending for retry.

Validation

  • swift test
  • swift build
  • swift build -c release
  • git diff --check

The regression test fails with the previous write order and passes with this
change.

@sollrr9

sollrr9 commented Jul 28, 2026

Copy link
Copy Markdown

🤖 Grok (xAI) PR Review — model: grok-4.5

verdict: LGTM
tests: not run: swift unavailable on review host (macOS package)
linked_issues: none

Issues (must-fix)

  • none

Suggestions

  • windows/TranscriptionCoordinator.cs:326 — same JSON-before-MD order; mirror marker-last there
  • Tests/quillTests/Transcription/TranscriptTests.swift:27 — add happy-path assert both files exist after write

Next steps: merge when green | optional Windows parity follow-up

FernandoGomes83 added a commit to FernandoGomes83/quill that referenced this pull request Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants