exit 0 when the model id is unknown - #20
Open
andredezzy wants to merge 1 commit into
Open
Conversation
Same defect as the accessibility path: `unknown model` throws ExitCode(1), and
the LaunchAgent sets KeepAlive{SuccessfulExit: false}, so launchd relaunches the
daemon, which prints the same error and exits again.
Observed after pointing the agent at an id that was not in the registry:
unknown model: whisper-large-v3-turbo-compressed
run `parrot models list` to see options.
unknown model: whisper-large-v3-turbo-compressed
run `parrot models list` to see options.
unknown model: whisper-large-v3-turbo-compressed
A wrong id in a plist cannot fix itself by being retried. Exit 0 so the user gets
the message once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
runthrowsExitCode(1)when--modelnames an id that is not in theregistry. The LaunchAgent written by
parrot install --launch-at-loginsetsKeepAlive{SuccessfulExit: false}, so launchd relaunches the daemon, whichprints the same error and exits again.
Observed on macOS 26.4.1 after pointing the agent at an id that did not exist:
A wrong id in a plist cannot fix itself by being retried, so every relaunch is
guaranteed to fail the same way. Dictation is silently dead while launchd spins.
Fix
Exit 0. The user still gets the message and the pointer to
parrot models list,once instead of on a loop.
Relationship to the accessibility path
This is the same defect in a second place — a non-transient failure exiting
nonzero under
KeepAlive. The accessibility case is the one users are morelikely to hit (a new release invalidates the TCC grant, since the shipped
binaries are
adhoc, linker-signedand TCC then anchors to the cdhash), and itproduced nine permission dialogs in a row on this machine. Both fixes are
one-liners and independent; either can land alone.
Built locally with
swift build -c release(no PR CI in this repo); clean, nowarnings.