models list: stop truncating ids - #19
Open
andredezzy wants to merge 1 commit into
Open
Conversation
`padding(toLength:)` truncates when the string is longer than the target, so any id past 26 characters was printed cut off — and a cut id cannot be pasted into `parrot models download`. Size the column to the longest id instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
models listpads the id column withpadding(toLength: 26, …), and Swift'spadding(toLength:)truncates when the string is longer than the target. Anyid past 26 characters is printed cut off, and a cut id cannot be pasted into
parrot models download.Reproducible with any longer id. Adding a 33-character one to the registry:
The command's whole purpose is to give the user a value to copy, so silently
corrupting it defeats the feature.
Fix
Size the column to the longest id in the registry instead of a fixed 26. Output
with the same registry:
Current ids all fit in 26 characters, so nothing changes for them today — this
only stops the next longer id from being mangled.
Built locally with
swift build -c release(no PR CI in this repo); clean, nowarnings.