add --hotkey option to pick the push-to-talk key (fn or right-option) - #10
Open
tomiiide wants to merge 1 commit into
Open
add --hotkey option to pick the push-to-talk key (fn or right-option)#10tomiiide wants to merge 1 commit into
tomiiide wants to merge 1 commit into
Conversation
The README documents --hotkey right-option but the code hardwired fn. Right option matches keycode 61 so the left key stays free for typing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Implements the
--hotkeyrun option that the README already documents (parrot --hotkey right-option) but the code never wired up:HotkeyMonitorwas hardcoded to fn.--hotkey fn(default): unchanged behavior.--hotkey right-option: watches flagsChanged for the option mask filtered to keycode 61, so the left option key stays free for normal typing.Why
On the current macOS 27 developer beta (26A5388g, M1 MacBook Pro), the system stops delivering the bare fn flagsChanged event (keycode 63) to event taps entirely: fn still works as a modifier for other keys, but no standalone press event ever reaches the tap, so hold-fn push-to-talk can never trigger. Verified with an independent event-tap logger and
--debug-hotkey: every other modifier arrives, fn alone is absent. An alternative hotkey makes parrot usable there (and for anyone whose fn key is otherwise claimed).Testing
Built and ran on the affected machine.
--hotkey right-option: press/release cycles record, transcribe, and type correctly, left option does not trigger it. Default fn path unchanged (verified via synthesized fn flagsChanged events, since the hardware key never emits on this OS build).