Skip to content

chore: remove srxconfutils pip install from ci and update package entry point#43

Merged
sbillinge merged 4 commits into
diffpy:mainfrom
zmx27:remove-pip
Nov 15, 2025
Merged

chore: remove srxconfutils pip install from ci and update package entry point#43
sbillinge merged 4 commits into
diffpy:mainfrom
zmx27:remove-pip

Conversation

@zmx27

@zmx27 zmx27 commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

Closes #37

@zmx27

zmx27 commented Nov 13, 2025

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for review

@codecov

codecov Bot commented Nov 13, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (7b9a5ea) to head (161debe).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #43   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           48        48           
=========================================
  Hits            48        48           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge sbillinge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comments

Comment thread README.rst
This package also provides command-line utilities. To check the software has been installed correctly, type ::

diffpy.srxplanar --version
diffpy-srxplanar --version

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the command line app can just be called srxplanar. Less for folks to type

@sbillinge

Copy link
Copy Markdown
Contributor

@zmx27 please let me know when you make this change (change the script name in pyproject.toml to just srxplanar so the user just has to type srxplanar at the command line (easier to remember and less to type).

Please could you also check the docs to make sure they build properly and can be followed?

@sbillinge sbillinge merged commit 2c02eb3 into diffpy:main Nov 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove pip install

2 participants