chore: remove noqas introduced during skpkging#38
Conversation
|
@sbillinge ready for review. After removing all |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
=======================================
Coverage 50.00% 50.00%
=======================================
Files 2 2
Lines 18 18
=======================================
Hits 9 9
Misses 9 9 🚀 New features to boost your workflow:
|
| rcParams["backend"] = "Qt4Agg" | ||
| try: | ||
| import PySide # noqa: F401 | ||
| importlib.import_module("PySide") |
There was a problem hiding this comment.
this looks to me like legacy py2 or earlier python versions. Can we get rid of this logic and just import latest versions of things at the top? We are just supporting 3.11 - 3.13 (initially) then 2.12-3.14 later
| @@ -1,24 +1,17 @@ | |||
| from functools import partial | |||
There was a problem hiding this comment.
The way I changed this file is that I removed the PySide import and just setting rcParams to QtAgg to allow matplotlib to detect the version of pyside to use (PySide6 or PySide2). I also put all of these matplotlib imports inside the try block, as the presence of mplenabled tells me that matplotlib and PySide are optional dependencies and do not necessarily have to be installed.
|
Fantastic! |
Closes #18