Skip to content

skpkg: update names to comply with skpkg standards#31

Closed
cadenmyers13 wants to merge 3 commits into
diffpy:mainfrom
cadenmyers13:skpkg-naming
Closed

skpkg: update names to comply with skpkg standards#31
cadenmyers13 wants to merge 3 commits into
diffpy:mainfrom
cadenmyers13:skpkg-naming

Conversation

@cadenmyers13

Copy link
Copy Markdown
Contributor

changed doc to docs and replaced underscores with hyphens in code of conduct.

@codecov

codecov Bot commented Aug 7, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.67%. Comparing base (d70d879) to head (7fffeb4).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   75.67%   75.67%           
=======================================
  Files           3        3           
  Lines          37       37           
=======================================
  Hits           28       28           
  Misses          9        9           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge ready for merge. docs didn't deploy because this naming convention change

@sbillinge

Copy link
Copy Markdown
Contributor

I think this will conflict with @Tieqiong's PR so I will hold off merging this for now. Let's leave it open though until we are sure and close it after that one merges successfully.

@cadenmyers13

Copy link
Copy Markdown
Contributor Author

@sbillinge okay, I'll keep an eye on that one and ping you to merge once Tieqiongs PR goes through

@cadenmyers13

Copy link
Copy Markdown
Contributor Author

Oh I just looked at that PR and it looks like Tieqiong handled this so this PR is probably unnecessary but I'll leave it for now

@sbillinge

Copy link
Copy Markdown
Contributor

great! Let me know when current cmi on CF passes all the tutorials. When @Tieqiong's passes CI I can merge that and we go again.

@Tieqiong

Copy link
Copy Markdown
Contributor

@sbillinge the CI is passing, it's just codecov/project failing because the coverage dropped by 25% (due to me removing the skpkg template test)...

@sbillinge

Copy link
Copy Markdown
Contributor

@sbillinge the CI is passing, it's just codecov/project failing because the coverage dropped by 25% (due to me removing the skpkg template test)...

ah, ok.

@cadenmyers13

Copy link
Copy Markdown
Contributor Author

Closing as complete by tieqiongs PR

@cadenmyers13 cadenmyers13 deleted the skpkg-naming branch October 28, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants