Skip to content

Adding testing evironment to the lint and build yaml files for github actions #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vratins merged 2 commits into from
Mar 26, 2026
Merged

Adding testing evironment to the lint and build yaml files for github actions #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ae7b2c
adding testing environment for github workflows
vratins Mar 25, 2026
f7d1a5a
addressing comments
vratins Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,7 @@ on:
jobs:
build:
runs-on: ubuntu-latest

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change only causes a manual approval gate if the testing environment is configured in the repo settings with required reviewers/protection rules. If it isn’t configured (or doesn’t exist yet), the job will run without approval, so you may want to document/setup the environment as part of this PR (or add a note in the workflow/README).

Suggested change
runs-on: ubuntu-latest
runs-on: ubuntu-latest
# NOTE: This only enforces a manual approval gate if the `testing`
# environment is configured in the repository settings with required
# reviewers/protection rules. Otherwise, this job will run without
# manual approval.

Copilot uses AI. Check for mistakes.
strategy:
matrix:
python-version: [3.12]

environment: testing
Comment thread
coderabbitai[bot] marked this conversation as resolved.
# Skip CI if 'skip ci' is in the latest commit message (only relevant for push/pull_request triggers)
# if: "!contains(github.event.head_commit.message, 'skip ci')"
# Will add back on skipping for draft PRs too.
Expand All @@ -30,11 +27,10 @@ jobs:
steps:
- uses: actions/checkout@v6

- name: Setup UV and python version
- name: Setup UV
uses: astral-sh/setup-uv@v7
with:
version: "0.10.6"
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: uv sync --group dev
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ on:
jobs:
ruff:
runs-on: ubuntu-latest
environment: testing
permissions:
Comment on lines 9 to 12

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding environment: testing means this lint job will now wait for environment approval on every run, including workflow_dispatch. If the intent is to gate only PR-triggered executions, consider restricting the environment usage to pull_request runs (e.g., split jobs or conditionally run a gated variant).

Copilot uses AI. Check for mistakes.
contents: write

Expand All @@ -34,6 +35,7 @@ jobs:

ty:
runs-on: ubuntu-latest
environment: testing

Comment on lines 36 to 39

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above: environment: testing will require approval for this job on every trigger path. If you only want PR gating, avoid applying the protected environment to non-PR runs (e.g., workflow_dispatch).

Copilot uses AI. Check for mistakes.
steps:
- uses: actions/checkout@v6
Expand Down
Loading