Skip to content

fixing max comparison error#67

Merged
vratins merged 1 commit into
mainfrom
dev_dataset_updates
Mar 23, 2026
Merged

fixing max comparison error#67
vratins merged 1 commit into
mainfrom
dev_dataset_updates

Conversation

@vratins

@vratins vratins commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

just changing 1 line of code that I missed in the merge that was stalling tests.

Copilot AI review requested due to automatic review settings March 23, 2026 19:50
@coderabbitai

coderabbitai Bot commented Mar 23, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@vratins has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 52 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: dfe1b331-bbc5-465f-959c-835a4d2a10c6

📥 Commits

Reviewing files that changed from the base of the PR and between 8dcfc69 and 6721d6f.

📒 Files selected for processing (1)
  • src/dataset.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev_dataset_updates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a normalization bug in compute_normalized_bfactors that could stall execution/tests due to incorrect use of np.max when clamping the denominator.

Changes:

  • Replace np.max(water_std, 1e-3) with max(water_std, 1e-3) to correctly clamp a scalar standard deviation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vratins
vratins merged commit e4a722c into main Mar 23, 2026
8 checks passed
@vratins
vratins deleted the dev_dataset_updates branch July 16, 2026 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants