fixing max comparison error#67
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Fixes a normalization bug in compute_normalized_bfactors that could stall execution/tests due to incorrect use of np.max when clamping the denominator.
Changes:
- Replace
np.max(water_std, 1e-3)withmax(water_std, 1e-3)to correctly clamp a scalar standard deviation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
just changing 1 line of code that I missed in the merge that was stalling tests.