-
Notifications
You must be signed in to change notification settings - Fork 1
Minimal refactor tests #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| import os | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
| import torch | ||
|
|
||
| TEST_DIR = Path(__file__).parent | ||
| ENV_PDB_DIR = os.environ.get("ENV_PDB_DIR") | ||
| PDB_BASE_DIR = Path(ENV_PDB_DIR) if ENV_PDB_DIR else TEST_DIR / "test_files" | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def device(): | ||
| return torch.device("cuda" if torch.cuda.is_available() else "cpu") | ||
|
|
||
| @pytest.fixture(scope="session") | ||
| def pdb_base_dir(): | ||
| """Wrapper of constant PDB_BASE_DIR. | ||
| """ | ||
| return PDB_BASE_DIR | ||
|
|
||
|
|
||
| def _resolve_pdb_path(pdb_id): | ||
| """Resolves a PDB path, skipping if missing.""" | ||
| path = PDB_BASE_DIR / pdb_id / f"{pdb_id}_final.pdb" | ||
| if not path.exists(): | ||
| pytest.skip(f"PDB file not found: {path}") | ||
| return str(path) | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def pdb_6eey(): | ||
| """6eey - standard PDB that passes all quality checks.""" | ||
| return _resolve_pdb_path("6eey") | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def pdb_2b5w(): | ||
| """2b5w - fails COM distance check.""" | ||
| return _resolve_pdb_path("2b5w") | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def pdb_8dzt(): | ||
| """8dzt - fails water clash check at 2% threshold with 2A distance.""" | ||
| return _resolve_pdb_path("8dzt") | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def pdb_1deu(): | ||
| """1deu - has insertion codes (52 residues with ins_code='P').""" | ||
| return _resolve_pdb_path("1deu") | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be a fixture? It will certainly work, but it will call os.environ.get every time you want to get what is essentially a constant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good point. a new commit will make a constant first, and just wrap it in a fixture to not affect the existing test functions.