Skip to content

Voltage Park migration -- set up workflows and pre-commit #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DorisMai merged 12 commits into from
Mar 10, 2026
Merged

Voltage Park migration -- set up workflows and pre-commit #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3e2f85f
Add pre-commit config and build workflow
Mar 1, 2026
8e8c42a
added more pre-commit and auto-commit. skip ci.
Mar 1, 2026
d40139d
fixing type check. skip ci.
Mar 2, 2026
c2a8a19
removing dev dependencies from main dependency group.
Mar 2, 2026
7ac377c
removing dependencies not used.
Mar 2, 2026
094c59d
removing nvidia-cu12 related dependencies. torch should hopefully han…
Mar 2, 2026
fdd9fb7
Remove transitive and nvidia-cu12 noise from pyproject.toml
Mar 2, 2026
22ae089
removes most dependency version constraints
Mar 2, 2026
73bd0c1
reverting dependency changes, as they are covered in PR 45. skip ci.
Mar 4, 2026
88d333e
added test coverage to build workflow, and changed mypy to ty.
Mar 5, 2026
7d22355
keeping build workflow as manual trigger for now
Mar 9, 2026
9c83b99
fixes ruff/ty set up
DorisMai Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: Build

@marcuscollins marcuscollins Mar 5, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this yet? I'm not sure this package will build on the standard GitHub runners (in fact, I'm pretty sure it won't, since there are CUDA requirements like torch-geometric, but I could be wrong). We want to do this kind of testing (I have a similar file for sampleworks waiting in the wings) but we need our own runners first. Moody has this in the works, and it should be ready next week AFAIK.

@DorisMai DorisMai Mar 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build with the existing pyproject.toml actually ran fine? Technically the torch related packages can be installed with cpu kernels and the current tests don't seem to require gpu. But yes I am aware that the current workflow won't work for gpu explicit test. look forward to our own runner.


on:
# push:
# branches: [main]
# pull_request:
# branches: [main]
workflow_dispatch:
Comment on lines +4 to +8

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The push and pull_request triggers for the Build workflow are commented out, meaning this workflow is only triggered manually via workflow_dispatch. The PR description explicitly states the goal is to "force all pushes and PR on the main branch to pass the pytests." With the current configuration, the build/test step will never run automatically on pushes or pull requests. The trigger section should be uncommented to achieve the stated goal.

Copilot uses AI. Check for mistakes.

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [3.12]

# Skip CI if 'skip ci' is in the latest commit message (only relevant for push/pull_request triggers)
# if: "!contains(github.event.head_commit.message, 'skip ci')"
# Will add back on skipping for draft PRs too.
# if: |
# !contains(github.event.head_commit.message, 'skip ci') &&
# (github.event_name != 'pull_request' || !github.event.pull_request.draft)

steps:
- uses: actions/checkout@v6

- name: Setup UV and python version
uses: astral-sh/setup-uv@v7
with:
version: "0.10.6"
python-version: ${{ matrix.python-version }}

- name: Install dependencies
run: uv sync --group dev

- name: Run tests
env:
TEST_DATA_DIR: ${{ github.workspace }}/tests/test_files
run: uv run pytest tests/ --cov=src --cov-report=html --cov-report=term-missing --cov-fail-under=80
45 changes: 45 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
name: Lint

on:
# pull_request:
# branches: [main]
workflow_dispatch:

jobs:
ruff:
runs-on: ubuntu-latest
permissions:
contents: write

steps:
- uses: actions/checkout@v6
with:
ref: ${{ github.head_ref }}

Copilot AI Mar 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The github.head_ref context variable is only populated for pull_request events, not for push events. Since this workflow triggers on both push and pull_request (lines 4–7), when a push to main occurs, github.head_ref will be an empty string. Passing an empty string as the ref parameter to actions/checkout may cause unexpected behavior (checking out an empty ref or failing). Consider using a conditional such as ref: ${{ github.event_name == 'pull_request' && github.head_ref || github.ref }} to handle both trigger types correctly.

Suggested change
ref: ${{ github.head_ref }}
ref: ${{ github.event_name == 'pull_request' && github.head_ref || github.ref }}

Copilot uses AI. Check for mistakes.
token: ${{ secrets.GITHUB_TOKEN }}

- name: Install ruff
run: pip install ruff

- name: Auto-fix with ruff
run: |
ruff check --fix .
ruff format .

- name: Commit ruff fixes
uses: stefanzweifel/git-auto-commit-action@v5
with:
commit_message: "Auto-commit ruff fixes [skip ci]"
commit_username: "Autoformatter"
commit_email: "actions@github.com"

ty:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v6

- name: Setup UV and python version
uses: astral-sh/setup-uv@v7

- name: Run ty
run: uvx ty check src/
18 changes: 18 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.15.0
hooks:
# Run the linter.
- id: ruff-check
args: [--verbose, --fix]
# Run the formatter.
- id: ruff-format
args: [--verbose]

- repo: local
hooks:
- id: ty
name: ty check
entry: uv run ty check
language: system
types: [python]