Skip to content

Add jsnext:main support#24

Open
dandv wants to merge 1 commit into
diegohaz:masterfrom
dandv:patch-1
Open

Add jsnext:main support#24
dandv wants to merge 1 commit into
diegohaz:masterfrom
dandv:patch-1

Conversation

@dandv

@dandv dandv commented Jun 8, 2017

Copy link
Copy Markdown

See jsforum/jsforum#5 and note that while jsnext:main has been superseded by pkg.module (which might get standardized), popular modules like redux and three.js still declare (only) jsnext:main.

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           1      1           
  Branches        1      1           
=====================================
  Hits            1      1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 370276e...50b2390. Read the comment docs.

@diegohaz

diegohaz commented Jun 8, 2017

Copy link
Copy Markdown
Owner

Thank you, @dandv. I'll take a time to read that issue.

But looking at it, shouldn't we add src to files then? Otherwise src will not be published to npm.

@dandv

dandv commented Jun 8, 2017

Copy link
Copy Markdown
Author

I've just updated the OP - pkg.module has superseded jsnext:main, and module might get standardized.

Indeed, src should be added to files. I'll let you have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants