fix: matplotlib boxplot compat for montecarlo maxdd plot - #15
Merged
Conversation
html_montecarlo crashed on matplotlib 3.7–3.9 because maxdd_distribution_figure used orientation=/tick_labels= (3.9+/3.10+ only). Route those kwargs through a signature-based shim so the declared matplotlib>=3.7 floor works through 3.11+. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
html_montecarloMax Drawdown boxplot crashing on matplotlib 3.7–3.9 withTypeErrorfrom unsupportedorientation=/tick_labels=kwargs.boxplot_compat_kwargs()shim so the plot works from matplotlib 3.7 through 3.11+.0.4.5with CHANGELOG entry and regression tests.Test plan
pytestpasses (260 tests)boxplot_compat_kwargs(legacy + modern signatures)maxdd_distribution_figurerender pathruff checkon touched fileshtml_montecarlosmoke on matplotlib 3.11Made with Cursor