fix(i18n): SEO/a11y follow-ups from PR #16 review - #17
Open
diecoscai wants to merge 1 commit into
Open
Conversation
… group Deferred items from PR #16 review: - og:locale + og:locale:alternate per locale (en_US/es_ES) - hreflang + lang attributes on all four EN/ES toggle anchors - role=group + localized aria-label on the corner controls container - Hide the mobile-menu language row from sm: up — the corner EN/ES pair already shows there, so the 640-767px band no longer offers two toggles Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VhYGxeedwYvmSNJFBkxwMK
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
EvidenceCaptured with Playwright against the production build ( Screenshots
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
en_US/es_ESon/, swapped on/es/role="group"+ localizedaria-label("Language and theme" / "Idioma y tema") via the typed i18n dictionarysm:hidden; the corner EN/ES pair (visible fromsm:) is the single toggle there, and below 640px the menu row remains the only oneContext
These are the technical items deferred from the PR #16 reviews. The ES copy-phrasing items from the same list are intentionally left out — they belong to the upcoming copy-rewrite session.
Changes
src/layouts/Base.astroog:locale+og:locale:alternatemeta, keyed off localesrc/components/CornerControls.astrorole="group"+ localizedaria-label;hreflang/langon EN/ES anchorssrc/components/Nav.astrohreflang/langon menu-row anchors; row hidden fromsm:upsrc/i18n/index.tscorner.groupUI string (EN + ES)Verification
astro check: 0 errors ·astro build: 2 pagesaria-labelon both locales,hreflang/langpresent on all 4 anchors,og:localecorrect per page; at 700px the open menu shows no language row while the corner pair shows; at 375px the menu row showsEvidence screenshots in comment below.
Test plan
npx astro check— 0 errorsnpm run build— 2 pages builtRelated: #16
🤖 Generated with Claude Code
https://claude.ai/code/session_01VhYGxeedwYvmSNJFBkxwMK