fix: handle missing dependencies in vm.t, apply code formatting, and fix CI dependency installation

.gitignore

@@ -2,6 +2,7 @@
 *.o
 .openhvf/
 build/
+local/
 
 # Exploratory testing
 explore/

lib/FuguLib/Daemon.pm

@@ -29,7 +29,7 @@
 #	%args:
 #		logfile => $path  # Where to redirect stdout/stderr (default: /dev/null)
 #		on_fork => sub($) # Callback after fork, receives PID in parent
-sub daemonize( $class, %args )
+sub daemonize ( $class, %args )
 {
 	my $logfile = $args{logfile} // '/dev/null';
 	my $on_fork = $args{on_fork};
@@ -47,7 +47,7 @@
 	}
 
 	# Child process
 	$DB::inhibit_exit = 0;
 	setsid() or die "Cannot start new session: $!";
 
 	# Redirect standard file descriptors

lib/FuguLib/Log.pm

@@ -33,7 +33,7 @@ use constant {
 	MODE_QUIET  => 'quiet',
 };
 
-sub new( $class, %args )
+sub new ( $class, %args )
 {
 	my $mode  = $args{mode}  // MODE_STDERR;
 	my $level = $args{level} // 'info';
@@ -66,26 +66,26 @@ sub new( $class, %args )
 	return $self;
 }
 
-sub DESTROY($self)
+sub DESTROY ($self)
 {
 	if ( $self->{opened} && $self->{mode} eq MODE_SYSLOG ) {
 		closelog();
 	}
 }
 
 # Logging methods
-sub debug( $self, $fmt, @args )   { $self->_log( 'debug',   $fmt, @args ); }
-sub info( $self, $fmt, @args )    { $self->_log( 'info',    $fmt, @args ); }
-sub notice( $self, $fmt, @args )  { $self->_log( 'notice',  $fmt, @args ); }
-sub warning( $self, $fmt, @args ) { $self->_log( 'warning', $fmt, @args ); }
-sub warn( $self, $fmt, @args )    { $self->_log( 'warning', $fmt, @args ); }
-sub error( $self, $fmt, @args )   { $self->_log( 'error',   $fmt, @args ); }
-sub err( $self, $fmt, @args )     { $self->_log( 'error',   $fmt, @args ); }
-sub crit( $self, $fmt, @args )    { $self->_log( 'crit',    $fmt, @args ); }
+sub debug   ( $self, $fmt, @args ) { $self->_log( 'debug',   $fmt, @args ); }
+sub info    ( $self, $fmt, @args ) { $self->_log( 'info',    $fmt, @args ); }
+sub notice  ( $self, $fmt, @args ) { $self->_log( 'notice',  $fmt, @args ); }
+sub warning ( $self, $fmt, @args ) { $self->_log( 'warning', $fmt, @args ); }
+sub warn    ( $self, $fmt, @args ) { $self->_log( 'warning', $fmt, @args ); }
+sub error   ( $self, $fmt, @args ) { $self->_log( 'error',   $fmt, @args ); }
+sub err     ( $self, $fmt, @args ) { $self->_log( 'error',   $fmt, @args ); }
+sub crit    ( $self, $fmt, @args ) { $self->_log( 'crit',    $fmt, @args ); }
 
 # $self->_log($level, $fmt, @args):
 #	Internal logging method
-sub _log( $self, $level, $fmt, @args )
+sub _log ( $self, $level, $fmt, @args )
 {
 	return if $self->{mode} eq MODE_QUIET;
 
@@ -107,7 +107,7 @@ sub _log( $self, $level, $fmt, @args )
 
 # $self->set_level($level):
 #	Change minimum log level
-sub set_level( $self, $level )
+sub set_level ( $self, $level )
 {
 	$self->{level} = _parse_level($level);
 }
@@ -146,19 +146,19 @@ my %facility_map = (
 	local7 => LOG_LOCAL7,
 );
 
-sub _parse_level($level)
+sub _parse_level ($level)
 {
 	$level = lc($level);
 	return $level_map{$level} // 1;    # Default to info
 }
 
-sub _level_to_priority($level)
+sub _level_to_priority ($level)
 {
 	$level = lc($level);
 	return $priority_map{$level} // LOG_INFO;
 }
 
-sub _parse_facility($facility)
+sub _parse_facility ($facility)
 {
 	$facility = lc($facility);
 	return $facility_map{$facility} // LOG_DAEMON;

lib/FuguLib/Privdrop.pm

@@ -42,7 +42,7 @@ use POSIX qw(setuid setgid);
 #
 #		# Now running as _openhap
 #		$server->run();
-sub drop_privileges( $class, %args )
+sub drop_privileges ( $class, %args )
 {
 	my $user = $args{user}
 	    or die "user parameter required for drop_privileges";

lib/FuguLib/Process.pm

@@ -40,7 +40,7 @@
 #		on_error  => sub($err)  # Optional: error callback
 #		on_success => sub($pid) # Optional: success callback
 #		check_alive => $seconds # Optional: wait and verify process is alive
-sub spawn_command( $class, %args )
+sub spawn_command ( $class, %args )
 {
 	my $cmd = $args{cmd}
 	    or return { success => 0, error => 'No command specified' };
@@ -69,7 +69,7 @@
 	if ( $pid == 0 ) {
 
 		# Child process
 		$DB::inhibit_exit = 0;
 
 		if ($daemonize) {
 
@@ -141,7 +141,7 @@
 # $class->is_alive($pid):
 #	Check if process is alive (not dead, not zombie)
 #	Returns 1 if alive, 0 if dead or doesn't exist or zombie
-sub is_alive( $class, $pid )
+sub is_alive ( $class, $pid )
 {
 	return 0 unless defined $pid;
 	return 0 unless $pid =~ /^\d+$/;
@@ -172,7 +172,7 @@
 #	%args:
 #		grace_period => $seconds # Time to wait after TERM before KILL (default: 5)
 #		on_kill      => sub()    # Called after successful kill
-sub terminate( $class, $pid, %args )
+sub terminate ( $class, $pid, %args )
 {
 	return 1 unless defined $pid;
 	return 1 unless $class->is_alive($pid);
@@ -218,7 +218,7 @@
 # $class->reap($pid):
 #	Attempt to reap a zombie process
 #	Returns 1 if process was reaped or doesn't exist, 0 if still running
-sub reap( $class, $pid )
+sub reap ( $class, $pid )
 {
 	return 1 unless defined $pid;
 	return 1 unless $pid =~ /^\d+$/;
@@ -234,7 +234,7 @@
 # $class->reap_all():
 #	Reap all zombie children (non-blocking)
 #	Returns count of children reaped
-sub reap_all($class)
+sub reap_all ($class)
 {
 	my $count = 0;
 	while ( waitpid( -1, WNOHANG ) > 0 ) {
@@ -246,7 +246,7 @@
 # $class->wait_exit($pid, $timeout):
 #	Wait for process to exit
 #	Returns 1 if process exited, 0 if timeout
-sub wait_exit( $class, $pid, $timeout = 30 )
+sub wait_exit ( $class, $pid, $timeout = 30 )
 {
 	my $start = time;
 	while ( time - $start < $timeout ) {
@@ -273,7 +273,7 @@
 #			args => [$port, $dir],
 #			daemonize => 1,
 #		);
-sub spawn_perl( $class, %args )
+sub spawn_perl ( $class, %args )
 {
 	my $code = delete $args{code}
 	    or return { success => 0, error => 'No code specified' };
@@ -298,7 +298,7 @@
 	my %default_paths;
 	for my $key (qw(privlib archlib sitelib sitearch vendorlib vendorarch))
 	{
 		my $path = $Config::Config{$key};
 		$default_paths{$path} = 1 if defined $path && length $path;
 	}
 

lib/FuguLib/Signal.pm

@@ -31,7 +31,7 @@ our $interrupted = 0;
 # Stack of cleanup handlers
 my @cleanup_handlers;
 
-sub new($class)
+sub new ($class)
 {
 	bless {
 		handlers => {},
@@ -42,7 +42,7 @@ sub new($class)
 # $self->setup_graceful_exit(@signals):
 #	Setup handlers for graceful exit on specified signals
 #	Calls all registered cleanup handlers and exits
-sub setup_graceful_exit( $self, @signals )
+sub setup_graceful_exit ( $self, @signals )
 {
 	for my $sig (@signals) {
 		$self->{original}{$sig} = $SIG{$sig} // 'DEFAULT';
@@ -59,7 +59,7 @@ sub setup_graceful_exit( $self, @signals )
 # $self->setup_interrupt_flag(@signals):
 #	Setup handlers that set interrupt flag without exiting
 #	Allows long-running operations to check and exit cleanly
-sub setup_interrupt_flag( $self, @signals )
+sub setup_interrupt_flag ( $self, @signals )
 {
 	for my $sig (@signals) {
 		$self->{original}{$sig} = $SIG{$sig} // 'DEFAULT';
@@ -72,15 +72,15 @@ sub setup_interrupt_flag( $self, @signals )
 # $self->add_cleanup($handler):
 #	Add cleanup handler to be called on signal
 #	Handler receives signal name as argument
-sub add_cleanup( $self, $handler )
+sub add_cleanup ( $self, $handler )
 {
 	push @cleanup_handlers, $handler;
 	return $self;
 }
 
 # $self->restore():
 #	Restore original signal handlers
-sub restore($self)
+sub restore ($self)
 {
 	for my $sig ( keys %{ $self->{handlers} } ) {
 		$SIG{$sig} = $self->{original}{$sig};
@@ -104,7 +104,7 @@ sub reset_interrupted()
 	$interrupted = 0;
 }
 
-sub _run_cleanup_handlers( $self, $signal )
+sub _run_cleanup_handlers ( $self, $signal )
 {
 	for my $handler (@cleanup_handlers) {
 		eval { $handler->($signal); };
@@ -113,7 +113,7 @@ sub _run_cleanup_handlers( $self, $signal )
 }
 
 # DESTROY runs when object goes out of scope
-sub DESTROY($self)
+sub DESTROY ($self)
 {
 	$self->restore;
 }

lib/FuguLib/State.pm

@@ -26,7 +26,7 @@ use FuguLib::Process;
 #
 # Provides safe PID file reading/writing with locking and stale PID detection.
 
-sub new( $class, $pidfile )
+sub new ( $class, $pidfile )
 {
 	return unless defined $pidfile;
 
@@ -39,7 +39,7 @@ sub new( $class, $pidfile )
 # $self->write_pid($pid):
 #	Write PID to file with exclusive lock
 #	Returns 1 on success, 0 on failure
-sub write_pid( $self, $pid = $$ )
+sub write_pid ( $self, $pid = $$ )
 {
 	my $pidfile = $self->{pidfile};
 
@@ -57,7 +57,7 @@ sub write_pid( $self, $pid = $$ )
 # $self->read_pid():
 #	Read PID from file
 #	Returns PID or undef if not found or invalid
-sub read_pid($self)
+sub read_pid ($self)
 {
 	my $pidfile = $self->{pidfile};
 	return unless -f $pidfile;
@@ -74,7 +74,7 @@ sub read_pid($self)
 
 # $self->remove():
 #	Remove PID file
-sub remove($self)
+sub remove ($self)
 {
 	my $pidfile = $self->{pidfile};
 	return 1 unless -f $pidfile;
@@ -84,7 +84,7 @@ sub remove($self)
 # $self->is_running():
 #	Check if process from PID file is running
 #	Returns PID if running, undef otherwise
-sub is_running($self)
+sub is_running ($self)
 {
 	my $pid = $self->read_pid;
 	return unless defined $pid;
@@ -94,7 +94,7 @@ sub is_running($self)
 
 # $self->is_stale():
 #	Check if PID file is stale (process not running)
-sub is_stale($self)
+sub is_stale ($self)
 {
 	my $pid = $self->read_pid;
 	return 0 unless defined $pid;

lib/OpenHAP/Accessory.pm

@@ -2,7 +2,7 @@
 
 package OpenHAP::Accessory;
 
-sub new( $class, %args )
+sub new ( $class, %args )
 {
 	my $self = bless {
 		aid               => $args{aid},
@@ -21,7 +21,7 @@
 	return $self;
 }
 
-sub _add_accessory_info_service($self)
+sub _add_accessory_info_service ($self)
 {
 
 	require OpenHAP::Service;
@@ -89,21 +89,21 @@
 	push @{ $self->{services} }, $info;
 }
 
-sub add_service( $self, $service )
+sub add_service ( $self, $service )
 {
 	push @{ $self->{services} }, $service;
 }
 
-sub get_services($self)
+sub get_services ($self)
 {
 	return @{ $self->{services} };
 }
 
-sub get_service( $self, $type )
+sub get_service ( $self, $type )
 {
 	# Look up the full UUID if a short name is given
 	require OpenHAP::Service;
 	my $target_uuid = $OpenHAP::Service::SERVICE_TYPES{$type} // $type;
 
 	for my $service ( @{ $self->{services} } ) {
 		return $service if $service->{type} eq $target_uuid;
@@ -112,7 +112,7 @@
 	return;
 }
 
-sub get_characteristic( $self, $iid )
+sub get_characteristic ( $self, $iid )
 {
 	for my $service ( @{ $self->{services} } ) {
 		my $char = $service->get_characteristic($iid);
@@ -122,7 +122,7 @@
 	return;
 }
 
-sub to_json($self)
+sub to_json ($self)
 {
 	my @services;
 	for my $service ( @{ $self->{services} } ) {
@@ -135,18 +135,18 @@
 	};
 }
 
-sub identify($self)
+sub identify ($self)
 {
 	# Override in subclasses to implement identify functionality
 	# (e.g., blink LED, beep, etc.)
 }
 
-sub add_event_callback( $self, $callback )
+sub add_event_callback ( $self, $callback )
 {
 	push @{ $self->{event_callbacks} }, $callback;
 }
 
-sub notify_change( $self, $iid )
+sub notify_change ( $self, $iid )
 {
 	# Notify all registered callbacks about characteristic change
 	for my $callback ( @{ $self->{event_callbacks} } ) {