disable vc-dir-process-output-limit for diff-hl-dired - #294
Merged
Conversation
Owner
|
Thank you, that is a necessary workaround indeed. Maybe it will be possible to refine the upstream's change as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent upstream Emacs change (268e055e051 (“Limit VC-Dir status process output processing”)) introduced
vc-dir-process-output-limitvariable with default value of 3000 characters & changed VC backenddir-status-filesimplementations to callvc-dir-maybe-narrow-and-show-more-buttonbefore processing larger output.Basically if there are changes in excess of limit, emacs truncates the result and adds a button to rerun the refresh without a limit, introducing dependency on status process buffer’s
vc-parent-buffer, pointing to the VC-Dir buffer, which is not present when diff-hl ends up calling that code.This breaks diff-hl in dired, producing an error like this:
Proposed change is to not have that output limit in diff-hl’s private status buffer.