add new SCF diagnostic quantities for slateratom#112
Open
alexmaryewski wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another one from the old draft.
This PR adds two new diagnostic quantities to help track the SCF convergence: the occupied part of the eigenvalue spectrum and the orthogonalised [F,PS] commutator. The former helps to spot if the orbital energies (one quantity that goes directly into the SK files) are converging properly, the latter is just a popular convergence metric that is used by many quantum chemistry codes out there (Turbomole, for one), and thus its implementation would make direct comparison easier. None of the changes add new or alter existing functionality, but they are to help with further debugging whenever new extension to the code are made.
I'm not sure about the output format. In this PR, the new quantities take place of energy components in the output loop, like this:
I'm very welcome to your suggestions as to where to make them available instead of this.