permission matrix manipulation#434
Merged
Merged
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
c67e7ff to
5588849
Compare
SEQUOIIA
approved these changes
May 12, 2026
This was referenced May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🌟 Changes:
🎶 Notes:
The new endpoint for getting
rbac/permission-matrixsort of supercedes the existing one forrbac/get-assignable-permissions. We should at least keep the old one until the frontend is updated.It feels weird to have something called
Bootstrapthat is used for more than just bootstrapping 🫣❓ Question:
It seems okay that we have to update one role at a time when updating permissions.
However, it feels a little clunky in the frontend.
Should we simply allow PUTting all the permissions into the system in one fell swoop?